-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ipv6 support for bgp router peer, router interface and router #10375
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCompouteRouter_addIdentifierRangeBgp|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_Ipv4Basic|TestAccComputeRouterPeer_UpdateIpv4|TestAccComputeRouter_updateIdentifierRangeBgp |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCompouteRouter_addIdentifierRangeBgp|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_Ipv4Basic|TestAccComputeRouterPeer_UpdateIpv4|TestAccComputeRouter_updateIdentifierRangeBgp |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the new fields to the documentation? Thanks.
mmv1/third_party/terraform/services/compute/resource_compute_router_interface.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_router_peer.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_router_peer.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_router_bgp_peer_test.go.erb
Outdated
Show resolved
Hide resolved
Applying suggestion Co-authored-by: Zhenhua Li <[email protected]>
…outer_interface.go.erb Applying suggestion Co-authored-by: Zhenhua Li <[email protected]>
Added documentation |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRouterPeer_Ipv4BasicCreateUpdate|TestAccComputeRouter_addAndUpdateIdentifierRangeBgp |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
…oogleCloudPlatform#10375) Co-authored-by: Shivang Dixit <[email protected]> Co-authored-by: Zhenhua Li <[email protected]>
Adding ipv6 support for bgp router peer, router interface and router. Related to b/309454013
*Release Note Template for Downstream PRs