Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ipv6 support for bgp router peer, router interface and router #10375

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

Gorlami96
Copy link
Contributor

@Gorlami96 Gorlami96 commented Apr 5, 2024

Adding ipv6 support for bgp router peer, router interface and router. Related to b/309454013

*Release Note Template for Downstream PRs

compute: added `identifier_range` field to `google_compute_router` resource (beta)
compute: added `ip_version` field to `google_compute_router_interface` resource (beta)
compute: added `enable_ipv4`, `ipv4_nexthop_address` and `peer_ipv4_nexthop_address` fields to `google_compute_router_peer` resource (beta)

@Gorlami96 Gorlami96 marked this pull request as ready for review April 5, 2024 09:47
Copy link

github-actions bot commented Apr 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zli82016
Copy link
Member

zli82016 commented Apr 5, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 18 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 620 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 18 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 620 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 898
Passed tests: 820
Skipped tests: 72
Affected tests: 6

Click here to see the affected service packages
  • compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCompouteRouter_addIdentifierRangeBgp|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_Ipv4Basic|TestAccComputeRouterPeer_UpdateIpv4|TestAccComputeRouter_updateIdentifierRangeBgp

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 898
Passed tests: 819
Skipped tests: 72
Affected tests: 7

Click here to see the affected service packages
  • compute

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCompouteRouter_addIdentifierRangeBgp|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_Ipv4Basic|TestAccComputeRouterPeer_UpdateIpv4|TestAccComputeRouter_updateIdentifierRangeBgp

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCompouteRouter_addIdentifierRangeBgp[Debug log]
TestAccComputeRouterInterface_withIPVersionV4[Debug log]
TestAccComputeRouterInterface_withIPVersionV6[Debug log]
TestAccComputeRouterPeer_Ipv4Basic[Debug log]
TestAccComputeRouterPeer_UpdateIpv4[Debug log]
TestAccComputeRouter_updateIdentifierRangeBgp[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCompouteRouter_addIdentifierRangeBgp[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputeRouterInterface_withIPVersionV4[Debug log]
TestAccComputeRouterInterface_withIPVersionV6[Debug log]
TestAccComputeRouterPeer_Ipv4Basic[Debug log]
TestAccComputeRouterPeer_UpdateIpv4[Debug log]
TestAccComputeRouter_updateIdentifierRangeBgp[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying suggestion

Co-authored-by: Zhenhua Li <[email protected]>
@github-actions github-actions bot requested a review from zli82016 April 8, 2024 06:43
Gorlami96 and others added 2 commits April 8, 2024 12:27
@Gorlami96
Copy link
Contributor Author

@zli82016
Copy link
Member

zli82016 commented Apr 8, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 24 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 575 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 896
Passed tests: 822
Skipped tests: 72
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate|TestAccComputeRouter_addAndUpdateIdentifierRangeBgp

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate[Debug log]
TestAccComputeRouter_addAndUpdateIdentifierRangeBgp[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 4838a37 into GoogleCloudPlatform:main Apr 8, 2024
20 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants