Add enable_google_ml_integration setting to google_sql_database_insta…

[rsm3171990]

This PR adds support for the new field enable_google_ml_integration to google_sql_database_instance settings. This new field is only available for google.golang.org/api v0.170.0 or after. Locally tested the change and it works. Added Acctests (unit tests) and they passed.

Fixes hashicorp/terraform-provider-google#17785

Release Note Template for Downstream PRs (will be copied)

sql: added `enable_google_ml_integration` field to `google_sql_database_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 64 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 64 insertions(+), 1 deletion(-))

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 64 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 64 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 93
Passed tests: 4
Skipped tests: 14
Affected tests: 75

Click here to see the affected service packages

• sql

Action taken

Found 75 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccDataSourceSqlDatabaseInstances_basic|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabase_basic|TestAccDataSourceSqlDatabases_basic|TestAccSQLDatabaseInstance_DenyMaintenancePeriod|TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig|TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample|TestAccSqlClientCert_mysql|TestAccSqlClientCert_postgres|TestAccSqlDatabaseInstance_BackupRetention|TestAccSqlDatabaseInstance_Edition|TestAccSqlDatabaseInstance_Edition_Downgrade|TestAccSqlDatabaseInstance_EnableGoogleMlIntegration|TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer|TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccSqlDatabaseInstance_Smt|TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket|TestAccSqlDatabaseInstance_Timezone|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample|TestAccSqlDatabaseInstance_updateDifferentFlagOrder|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL|TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject|TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled|TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabase_basic|TestAccSqlDatabase_update|TestAccSqlUser_postgres|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleSQLCaCerts_basic[Debug log]
TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic[Debug log]
TestAccDataSourceSqlDatabaseInstance_basic[Debug log]
TestAccDataSourceSqlDatabaseInstances_basic[Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter[Debug log]
TestAccDataSourceSqlDatabaseInstances_tierFilter[Debug log]
TestAccDataSourceSqlDatabase_basic[Debug log]
TestAccDataSourceSqlDatabases_basic[Debug log]
TestAccSQLDatabaseInstance_DenyMaintenancePeriod[Debug log]
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig[Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig[Debug log]
TestAccSQLDatabase_sqlDatabaseBasicExample[Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample[Debug log]
TestAccSqlClientCert_mysql[Debug log]
TestAccSqlClientCert_postgres[Debug log]
TestAccSqlDatabaseInstance_BackupRetention[Debug log]
TestAccSqlDatabaseInstance_Edition[Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade[Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration[Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade[Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer[Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade[Debug log]
TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent[Debug log]
TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent[Debug log]
TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent[Debug log]
TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent[Debug log]
TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful[Debug log]
TestAccSqlDatabaseInstance_Smt[Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket[Debug log]
TestAccSqlDatabaseInstance_Timezone[Debug log]
TestAccSqlDatabaseInstance_activationPolicy[Debug log]
TestAccSqlDatabaseInstance_authNets[Debug log]
TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled[Debug log]
TestAccSqlDatabaseInstance_basicMSSQL[Debug log]
TestAccSqlDatabaseInstance_basicSecondGen[Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels[Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Debug log]
TestAccSqlDatabaseInstance_diskspecs[Debug log]
TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica[Debug log]
TestAccSqlDatabaseInstance_encryptionKey[Debug log]
TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion[Debug log]
TestAccSqlDatabaseInstance_highAvailability[Debug log]
TestAccSqlDatabaseInstance_insights[Debug log]
TestAccSqlDatabaseInstance_maintenance[Debug log]
TestAccSqlDatabaseInstance_maintenanceVersion[Debug log]
TestAccSqlDatabaseInstance_multipleOperations[Debug log]
TestAccSqlDatabaseInstance_replica[Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable[Debug log]
TestAccSqlDatabaseInstance_settingsDowngrade[Debug log]
TestAccSqlDatabaseInstance_settings_basic[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled[Debug log]
TestAccSqlDatabaseInstance_settings_secondary[Debug log]
TestAccSqlDatabaseInstance_settings_upgrade[Debug log]
TestAccSqlDatabaseInstance_slave[Debug log]
TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample[Debug log]
TestAccSqlDatabaseInstance_updateDifferentFlagOrder[Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled[Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Debug log]
TestAccSqlDatabase_basic[Debug log]
TestAccSqlDatabase_update[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccSqlUser_postgresAbandon[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[melinath]

It looks like the SQL user failure is known and probably unrelated: hashicorp/terraform-provider-google#16704

[melinath]

LGTM