-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource OrganizationEventThreatDetectionCustomModule #10769
Add Resource OrganizationEventThreatDetectionCustomModule #10769
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSecurityCenterOrganizationEventThreatDetectionCustomModule |
|
…gic-modules into securitycenter-management Merging remote branch updates into local
@vijaykanthm , do you mind signing Contributor License Agreement (CLA)? Thanks. More details here https://github.com/GoogleCloudPlatform/magic-modules/pull/10769/checks?check_run_id=25345996372 |
/gcbrun |
@zli82016 this link is not working for me, it says 'This site can’t be reached' |
When you click the |
Nope, it says the same. |
What about this link https://cla.developers.google.com/ ? |
I am actually a TVC may be I don't have access I guess, I am getting this message |
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withWorkloadALTSConfig|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample |
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
@vijaykanthm , the test |
Sure, will run it locally and make necessary changes if needed. |
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
1 similar comment
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
mmv1/products/securitycentermanagement/OrganizationEventThreatDetectionCustomModule.yaml
Outdated
Show resolved
Hide resolved
...management/resource_scc_management_organization_event_threat_detection_custom_module_test.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 104 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAppEngineFlexibleAppVersion_update|TestAccApphubWorkload_apphubWorkloadBasicExample|TestAccApphubWorkload_apphubWorkloadFullExample|TestAccApphubWorkload_apphubWorkloadUpdate|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccDNSManagedZoneIamBindingGenerated|TestAccDNSManagedZoneIamMemberGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccDNSManagedZone_dnsManagedZoneQuickstartExample|TestAccDataSourceApphubDiscoveredWorkload_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDefaultUniverseDomainDisk|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_stoppedSuspendedTargetSize|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample|TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample|TestAccNetworkServicesLbTrafficExtension_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample |
|
/gcbrun |
The related test I will rerun the tests to see if the failed tests decrease. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge the PR after the tests finish.
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAppEngineFlexibleAppVersion_update|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_update|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample |
|
Related to http://b/330538229.
fixes https://b.corp.google.com/issues/339718349
Requirement Doc: https://docs.google.com/document/d/1b97vduAO9BPiTTFa-muB9c9ACuDFlAOZW745PrkohXM/edit?tab=t.0#heading=h.cujlsysi3w59
Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/security-center-management/rest/v1/organizations.locations.eventThreatDetectionCustomModules
Release Note Template for Downstream PRs (will be copied)