Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource OrganizationEventThreatDetectionCustomModule #10769

Merged

Conversation

vijaykanthm
Copy link
Contributor

@vijaykanthm vijaykanthm commented May 22, 2024

Related to http://b/330538229.
fixes https://b.corp.google.com/issues/339718349

Requirement Doc: https://docs.google.com/document/d/1b97vduAO9BPiTTFa-muB9c9ACuDFlAOZW745PrkohXM/edit?tab=t.0#heading=h.cujlsysi3w59

Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/security-center-management/rest/v1/organizations.locations.eventThreatDetectionCustomModules

Release Note Template for Downstream PRs (will be copied)

`google_scc_management_organization_event_threat_detection_custom_module`

Copy link

google-cla bot commented May 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from zli82016 May 22, 2024 19:46
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/securitycenter and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 153 insertions(+))
google-beta provider: Diff ( 1 file changed, 153 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenter_management

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecurityCenterOrganizationEventThreatDetectionCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterOrganizationEventThreatDetectionCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…gic-modules into securitycenter-management

Merging remote branch updates into local
@zli82016
Copy link
Member

@vijaykanthm , do you mind signing Contributor License Agreement (CLA)? Thanks. More details here https://github.com/GoogleCloudPlatform/magic-modules/pull/10769/checks?check_run_id=25345996372

@zli82016
Copy link
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 23, 2024
@vijaykanthm
Copy link
Contributor Author

@vijaykanthm , do you mind signing Contributor License Agreement (CLA)? Thanks. More details here https://github.com/GoogleCloudPlatform/magic-modules/pull/10769/checks?check_run_id=25345996372

@zli82016 this link is not working for me, it says 'This site can’t be reached'

@zli82016
Copy link
Member

@vijaykanthm , do you mind signing Contributor License Agreement (CLA)? Thanks. More details here https://github.com/GoogleCloudPlatform/magic-modules/pull/10769/checks?check_run_id=25345996372

@zli82016 this link is not working for me, it says 'This site can’t be reached'

When you click the Details next to cla/google, can you open the link?

@vijaykanthm
Copy link
Contributor Author

@vijaykanthm , do you mind signing Contributor License Agreement (CLA)? Thanks. More details here https://github.com/GoogleCloudPlatform/magic-modules/pull/10769/checks?check_run_id=25345996372

@zli82016 this link is not working for me, it says 'This site can’t be reached'

When you click the Details next to cla/google, can you open the link?

Nope, it says the same.

@zli82016
Copy link
Member

cla/google

What about this link https://cla.developers.google.com/ ?

@vijaykanthm
Copy link
Contributor Author

cla/google

What about this link https://cla.developers.google.com/ ?

I am actually a TVC may be I don't have access I guess, I am getting this message
https://screenshot.googleplex.com/9Xud9GnYHQ38fJX

.ci/infra/terraform/main.tf Outdated Show resolved Hide resolved
@zli82016
Copy link
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 23, 2024
@github-actions github-actions bot requested a review from zli82016 May 23, 2024 21:26
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 23, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3728
Passed tests: 3343
Skipped tests: 373
Affected tests: 12

Click here to see the affected service packages
all service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withWorkloadALTSConfig|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags[Debug log]
TestAccContainerCluster_withWorkloadALTSConfig[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]
TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@zli82016
Copy link
Member

@vijaykanthm , the test TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule failed. Do you mind running the test locally to see if it passes? We recommend running the tests locally first during the development process. This is the doc https://googlecloudplatform.github.io/magic-modules/develop/test/run-tests/

@vijaykanthm
Copy link
Contributor Author

@vijaykanthm , the test TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule failed. Do you mind running the test locally to see if it passes? We recommend running the tests locally first during the development process. This is the doc https://googlecloudplatform.github.io/magic-modules/develop/test/run-tests/

Sure, will run it locally and make necessary changes if needed.

Copy link

github-actions bot commented Jun 1, 2024

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

1 similar comment
Copy link

github-actions bot commented Jun 2, 2024

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions bot requested a review from zli82016 June 3, 2024 22:38
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1597 insertions(+), 648 deletions(-))
google-beta provider: Diff ( 11 files changed, 1693 insertions(+), 754 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3747
Passed tests: 3267
Skipped tests: 376
Affected tests: 104

Click here to see the affected service packages
all service packages are affected

Action taken

Found 104 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccApphubWorkload_apphubWorkloadBasicExample|TestAccApphubWorkload_apphubWorkloadFullExample|TestAccApphubWorkload_apphubWorkloadUpdate|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccDNSManagedZoneIamBindingGenerated|TestAccDNSManagedZoneIamMemberGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccDNSManagedZone_dnsManagedZoneQuickstartExample|TestAccDataSourceApphubDiscoveredWorkload_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDefaultUniverseDomainDisk|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_stoppedSuspendedTargetSize|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample|TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample|TestAccNetworkServicesLbTrafficExtension_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccApphubWorkload_apphubWorkloadBasicExample[Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample[Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample[Debug log]
TestAccCloudBuildTrigger_webhook_config[Debug log]
TestAccCloudFunctionsFunction_secretEnvVar[Debug log]
TestAccCloudFunctionsFunction_secretMount[Debug log]
TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample[Debug log]
TestAccCloudRunService_cloudRunServiceSecretVolumesExample[Debug log]
TestAccCloudRunService_secretEnvironmentVariable[Debug log]
TestAccCloudRunService_secretVolume[Debug log]
TestAccComputeBackendService_withBackend[Debug log]
TestAccComputeBackendService_withBackendAndIAP[Debug log]
TestAccComputeBackendService_withBackendAndMaxUtilization[Debug log]
TestAccComputeBackendService_withMaxConnections[Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_update[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log]
TestAccComputeRegionPerInstanceConfig_update[Debug log]
TestAccDNSManagedZoneIamBindingGenerated[Debug log]
TestAccDNSManagedZoneIamMemberGenerated[Debug log]
TestAccDNSManagedZoneIamPolicyGenerated[Debug log]
TestAccDNSManagedZone_dnsManagedZoneQuickstartExample[Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic[Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_fromIGM[Debug log]
TestAccDefaultUniverseDomainDisk[Debug log]
TestAccIapTunnelInstanceIamBindingGenerated[Debug log]
TestAccIapTunnelInstanceIamBindingGenerated_withCondition[Debug log]
TestAccIapTunnelInstanceIamMemberGenerated[Debug log]
TestAccIapTunnelInstanceIamMemberGenerated_withCondition[Debug log]
TestAccIapTunnelInstanceIamPolicyGenerated[Debug log]
TestAccIapTunnelInstanceIamPolicyGenerated_withCondition[Debug log]
TestAccInstanceGroupManager_resourceManagerTags[Debug log]
TestAccInstanceGroupManager_stoppedSuspendedTargetSize[Debug log]
TestAccInstanceGroupManager_targetSizeZero[Debug log]
TestAccInstanceGroupManager_versions[Debug log]
TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log]
TestAccNetworkManagementConnectivityTest_update[Debug log]
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log]
TestAccNetworkServicesLbRouteExtension_update[Debug log]
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log]
TestAccNetworkServicesLbTrafficExtension_update[Debug log]
TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample[Debug log]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample[Debug log]
TestAccRegionInstanceGroupManager_APISideListRecordering[Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]
TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize[Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Debug log]
TestAccRegionInstanceGroupManager_versions[Debug log]
TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule[Debug log]
TestAccTags[Debug log]
TestAccTagsLocationTagBinding_locationTagBindingzonal[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAutoscaler_autoscalerBasicExample[Error message] [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]
TestAccComputeAutoscaler_multicondition[Error message] [Debug log]
TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControlFixed[Error message] [Debug log]
TestAccComputeAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeAutoscaler_update[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeRegionAutoscaler_update[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccInstanceGroupManager_basic[Error message] [Debug log]
TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log]
TestAccInstanceGroupManager_stateful[Error message] [Debug log]
TestAccInstanceGroupManager_update[Error message] [Debug log]
TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log]
TestAccIntegrationConnectorsConnection[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccRegionInstanceGroupManager_basic[Error message] [Debug log]
TestAccRegionInstanceGroupManager_update[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member

zli82016 commented Jun 4, 2024

/gcbrun

@zli82016
Copy link
Member

zli82016 commented Jun 4, 2024

The related test TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule passed.

I will rerun the tests to see if the failed tests decrease.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 4, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1597 insertions(+), 648 deletions(-))
google-beta provider: Diff ( 11 files changed, 1693 insertions(+), 754 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge the PR after the tests finish.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3747
Passed tests: 3340
Skipped tests: 376
Affected tests: 31

Click here to see the affected service packages
all service packages are affected

Action taken

Found 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_update|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccComputeAutoscaler_autoscalerBasicExample[Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Debug log]
TestAccComputeAutoscaler_multicondition[Debug log]
TestAccComputeAutoscaler_scaleDownControl[Debug log]
TestAccComputeAutoscaler_scaleInControl[Debug log]
TestAccComputeAutoscaler_scaleInControlFixed[Debug log]
TestAccComputeAutoscaler_scalingSchedule[Debug log]
TestAccComputeAutoscaler_update[Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Debug log]
TestAccComputeRegionAutoscaler_update[Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Debug log]
TestAccInstanceGroupManager_basic[Debug log]
TestAccInstanceGroupManager_self_link_unique[Debug log]
TestAccInstanceGroupManager_stateful[Debug log]
TestAccInstanceGroupManager_update[Debug log]
TestAccInstanceGroupManager_waitForStatus[Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Debug log]
TestAccRegionInstanceGroupManager_basic[Debug log]
TestAccRegionInstanceGroupManager_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccIntegrationConnectorsConnection[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants