Wbi resize disk

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

workbench: Added support for resizing disk

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 9 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 2 files changed, 9 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

This is currently generating a null update- I think we need to apply this to each of the leaf fields we intend to update.

[zli82016]

It looks like the update_url only works for root properties. https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/resource.erb#L821

Custom code is used to update disks in another PR, as updating disks needs a different method ResizeDisk. @rileykarson , does custom code sound reasonable to handle this case?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[bcreddy-gcp]

#10972

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[zli82016]

It looks like the custom code works to resize disks in #10972. Closing this PR.