pubsub: additional test permissions fixes

[wyardley]

Remove duplicated permissions, and work around terraform depends_on with some additional logic.

Rename terraform resources bigquery_foo_xxx instead of just editor / viewer, to avoid confusion with project viewer / editor roles.

Followup to #12095

I am pretty sure this will fix the last item; left the other two marked as "part of" in case this doesn't resolve those, but since those the two generated tests have test_vars_overrides for bootstrapping that this would have interfered with, hopefully this helps with any such issues.

Part of hashicorp/terraform-provider-google#20274
Part of hashicorp/terraform-provider-google#20262
Fixes hashicorp/terraform-provider-google#20261

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[wyardley]

Hopefully this resolves some or all of the issues from my previous PR. Heads up to @melinath @SarahFrench

[wyardley]

this and the other changes in this file shouldn't change any behavior -- just a slight readability / understandability adjustment.

I can revert the changes in this file if desired.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 3 files changed, 25 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 8 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 53
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• pubsub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubSubscriptionBigQuery_serviceAccount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscriptionBigQuery_serviceAccount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test