Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cgroup_mode in node_pool_auto_config #12382

Merged

Conversation

norbertcyran
Copy link
Contributor

This PR adds support for configuring cgroup mode in auto-provisioned node pools (see https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2).

Bug: b/363975773

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `node_pool_autoconfig.linux_node_config.cgroup_mode` field to `google_container_cluster` resource

@github-actions github-actions bot requested a review from zli82016 November 21, 2024 16:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 21, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 153 insertions(+))
google-beta provider: Diff ( 4 files changed, 153 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 218
Passed tests: 204
Skipped tests: 12
Affected tests: 2

Click here to see the affected service packages
  • container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withCgroupMode
  • TestAccContainerCluster_withCgroupModeUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withCgroupMode [Debug log]
TestAccContainerCluster_withCgroupModeUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit c3694fb into GoogleCloudPlatform:main Nov 22, 2024
12 checks passed
@norbertcyran norbertcyran deleted the cgroup-migration-support branch November 25, 2024 10:32
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants