Adding initial support for GCF Gen2 terraform integration #5670

k-ezis · 2022-02-01T15:11:18Z

Added API and Terraform yamls as well as an example for generating tests.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloudfunctions2_function`

modular-magician · 2022-02-01T15:11:35Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-02-01T15:12:13Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician · 2022-02-01T15:25:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 2285 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 2285 insertions(+), 2 deletions(-))
TF Validator: Diff ( 10 files changed, 2909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 116 insertions(+))

modular-magician · 2022-02-01T17:39:24Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated|TestAccComputeBackendServiceIamMemberGenerated|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated_withCondition|TestAccComputeBackendServiceIamMemberGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccCloudFunctions2CloudFunction_cloudfunctions2BasicExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeGlobalForwardingRule_externalCndLbWithBackendBucketExample|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioning|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=251031

rileykarson

Made an initial pass- I haven't read the resource proper in depth yet as the test failed, so these are mostly nits and structural.

The test failure was due to the generated name mismatching the resource name in the example:


Copy to clipboard
------- Stdout: -------
=== RUN   TestAccCloudFunctions2CloudFunction_cloudfunctions2BasicExample
=== PAUSE TestAccCloudFunctions2CloudFunction_cloudfunctions2BasicExample
=== CONT  TestAccCloudFunctions2CloudFunction_cloudfunctions2BasicExample
provider_test.go:286: Step 1/2 error: Error running pre-apply refresh: exit status 1
There are some problems with the CLI configuration:
Error: The specified plugin cache dir /opt/teamcity-agent/work/2e51954ade9939a/.provider-cache cannot be opened: stat /opt/teamcity-agent/work/2e51954ade9939a/.provider-cache: no such file or directory
As a result of the above problems, Terraform may not behave as intended.
Error: Invalid resource type
on terraform_plugin_test.tf line 2, in resource "google_cloudfunctions2_cloud_function" "function":
2: resource "google_cloudfunctions2_cloud_function" "function" {
The provider provider.google does not support resource type
"google_cloudfunctions2_cloud_function".
--- FAIL: TestAccCloudFunctions2CloudFunction_cloudfunctions2BasicExample (6.71s)
FAIL

mmv1/products/cloudfunctions2/api.yaml

rileykarson · 2022-02-01T17:56:27Z

mmv1/products/cloudfunctions2/api.yaml

+    name: 'CloudFunction'
+    base_url: projects/{{project}}/locations/{{location}}/functions
+    create_verb: :POST
+    description: |


Would it be possible include a references section, similar to

magic-modules/mmv1/products/cloudbuild/api.yaml

Lines 33 to 36 in 4d63482

references: !ruby/object:Api::Resource::ReferenceLinks

guides:

'Automating builds using build triggers': 'https://cloud.google.com/cloud-build/docs/running-builds/automate-builds'

api: 'https://cloud.google.com/cloud-build/docs/api/reference/rest/v1/projects.triggers'

That'll link the API reference and a user guide from the provider docs for the resource.

On a similar note- are those docs published somewhere?

I don't think we have public docs since we're just going to Public Preview, I'll check with my lead on this one though. Let me know if you want to see the internal docs.

mmv1/products/cloudfunctions2/api.yaml

rileykarson · 2022-02-01T18:02:16Z

mmv1/products/cloudfunctions2/api.yaml

+        name: 'environment'
+        description: 'The environment the function is hosted on.'
+        values:
+          - :ENVIRONMENT_UNSPECIFIED


For all enums, X_UNSPECIFIED tends to be invalid to actually send to the API so we can omit it. If that's not the case, please ignore this though.

mmv1/products/cloudfunctions2/terraform.yaml

rileykarson · 2022-02-01T18:08:13Z

mmv1/products/cloudfunctions2/terraform.yaml

+--- !ruby/object:Provider::Terraform::Config
+overrides: !ruby/object:Overrides::ResourceOverrides
+  CloudFunction:  !ruby/object:Overrides::Terraform::ResourceOverride
+    id_format: 'projects/{{project}}/locations/{{region}}/functions/{{cloud_function}}'


Suggested change

id_format: 'projects/{{project}}/locations/{{region}}/functions/{{cloud_function}}'

id_format: 'projects/{{project}}/locations/{{region}}/functions/{{name}}'

Same below- this looks for a field on the resource ultimately, and cloud_function isn't one. name should be correct (we may need to fiddle with some overrides to get the right format, depending on the API response)

I'm running into issues with 404s on the test files, not sure I'm quite understanding this piece to ensure the API request/responses are coming through correctly. I updated it from cloud_function to name. I was taking after the Gen1 GCF configuration, but unsure if those test cases are correct.

mmv1/products/cloudfunctions2/api.yaml

modular-magician · 2022-02-04T09:44:50Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-02-04T09:58:12Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 2285 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 2285 insertions(+), 2 deletions(-))
TF Validator: Diff ( 10 files changed, 2909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 116 insertions(+))

modular-magician · 2022-02-04T10:24:40Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-02-04T10:38:45Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 2287 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 2287 insertions(+), 2 deletions(-))
TF Validator: Diff ( 10 files changed, 2911 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 116 insertions(+))

modular-magician · 2022-02-04T12:41:05Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolders_basic|TestAccDataSourceGoogleGlobalForwardingRule|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated|TestAccComputeBackendServiceIamMemberGenerated|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated_withCondition|TestAccComputeBackendServiceIamMemberGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudfunctions2function_cloudfunctions2BasicExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_externalCndLbWithBackendBucketExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_bfd|TestAccComputeRouterInterface_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioning|TestAccFolderIamAuditConfig_basic|TestAccFolderIamAuditConfig_addFirstExemptMember|TestAccFolderIamAuditConfig_update|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamAuditConfig_updateNoExemptMembers|TestAccFolderIamBinding_basic|TestAccFolderIamBinding_update|TestAccFolderIamMember_basic|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=252726

modular-magician · 2022-02-17T20:42:18Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-02-17T20:57:14Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 2284 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 2284 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 617 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))

modular-magician · 2022-02-17T23:06:20Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudfunctions2function_cloudfunctions2BasicExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=258554

modular-magician · 2022-02-18T09:28:00Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 2316 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 2316 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 617 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 141 insertions(+))

modular-magician · 2022-02-18T18:25:00Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 2321 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2321 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 617 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 141 insertions(+))

modular-magician · 2022-02-18T20:27:18Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudfunctions2function_cloudfunctions2BasicExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstanceTemplate_reservationAffinities|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=259131

modular-magician · 2022-02-18T20:58:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 2316 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2316 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 617 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 135 insertions(+))

modular-magician · 2022-02-18T23:02:52Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudfunctions2function_cloudfunctions2BasicExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=259138

modular-magician · 2022-02-18T23:22:00Z

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

rileykarson · 2022-02-23T23:39:50Z

quick note- handing off review to @c2thorn (my name won't disappear because I've left prior review comments, but you can ignore it)

c2thorn · 2022-03-01T17:51:43Z

mmv1/products/cloudfunctions2/api.yaml

+versions:
+  - !ruby/object:Api::Product::Version
+    name: ga
+    base_url: https://cloudfunctions.googleapis.com/v2alpha/


Is there a new v2 endpoint now that it's launched? Is alpha the one we want to go with?

We're still using v2alpha post-launch. Once we reach GA I believe our endpoint will be updated.

modular-magician · 2022-03-01T18:04:44Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 11 files changed, 2569 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2569 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 607 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 290 insertions(+))

c2thorn · 2022-03-01T18:40:16Z

/gcbrun

k-ezis · 2022-03-01T18:59:30Z

Re-added commit to fix rebase issue

modular-magician · 2022-03-01T19:13:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 563 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2571 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 290 insertions(+))

c2thorn · 2022-03-01T19:19:50Z

/gcbrun

c2thorn · 2022-03-01T19:27:44Z

/gcbrun

modular-magician · 2022-03-01T19:40:16Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 437 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2571 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 290 insertions(+))

modular-magician · 2022-03-01T19:41:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 437 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2571 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 290 insertions(+))

mmv1/third_party/terraform/resources/resource_cloudfunction2_function_test.go.erb

…unction_test.go.erb Co-authored-by: Cameron Thornton <[email protected]>

c2thorn · 2022-03-01T20:21:36Z

/gcbrun

modular-magician · 2022-03-01T20:21:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 444 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 297 insertions(+))

modular-magician · 2022-03-01T20:34:09Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 444 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 297 insertions(+))

mmv1/third_party/terraform/resources/resource_cloudfunction2_function_test.go.erb

…unction_test.go.erb

c2thorn · 2022-03-01T21:00:50Z

/gcbrun

modular-magician · 2022-03-01T21:13:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 444 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 297 insertions(+))

modular-magician · 2022-03-01T21:14:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 444 insertions(+))
Terraform Beta: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 297 insertions(+))

c2thorn

Tests passed from manual run, waiting for VCR tests before merging

…dPlatform#5670)

modular-magician requested a review from rileykarson February 1, 2022 15:12

rileykarson reviewed Feb 1, 2022

View reviewed changes

rileykarson mentioned this pull request Feb 16, 2022

Release 4.11.0 changelog hashicorp/terraform-provider-google-beta#4042

Merged

c2thorn mentioned this pull request Feb 17, 2022

apply ignore read to nested properties #5725

Closed

5 tasks

rileykarson requested a review from c2thorn February 23, 2022 23:39

c2thorn reviewed Mar 1, 2022

View reviewed changes

k-ezis closed this Mar 1, 2022

k-ezis force-pushed the master branch from 1c7d1a6 to c2d0c16 Compare March 1, 2022 18:57

Adding back configurations to fix rebase issue

0a6430d

k-ezis reopened this Mar 1, 2022

Updating handwritten test for beta

09a5b66

c2thorn requested changes Mar 1, 2022

View reviewed changes

mmv1/third_party/terraform/resources/resource_cloudfunction2_function_test.go.erb Outdated Show resolved Hide resolved

k-ezis and others added 2 commits March 1, 2022 11:58

Update mmv1/third_party/terraform/resources/resource_cloudfunction2_f…

a26f7e9

…unction_test.go.erb Co-authored-by: Cameron Thornton <[email protected]>

Updating provider to beta

ad167d3

c2thorn reviewed Mar 1, 2022

View reviewed changes

mmv1/third_party/terraform/resources/resource_cloudfunction2_function_test.go.erb Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/resources/resource_cloudfunction2_f…

2b0a882

…unction_test.go.erb

c2thorn approved these changes Mar 1, 2022

View reviewed changes

c2thorn merged commit 1a847cc into GoogleCloudPlatform:master Mar 2, 2022

slevenick mentioned this pull request Mar 3, 2022

Support Google Cloud Functions 2nd Gen hashicorp/terraform-provider-google#11210

Closed

c2thorn mentioned this pull request Mar 8, 2022

Change push-downstream oics and cloud-docs steps to use 'beta' #5802

Merged

5 tasks

modular-magician mentioned this pull request Mar 9, 2022

Change push-downstream oics and cloud-docs steps to use 'beta' terraform-google-modules/docs-examples#197

Merged

5 tasks

lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022

Adding initial support for GCF Gen2 terraform integration (GoogleClou…

2f707dd

…dPlatform#5670)

lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022

Adding initial support for GCF Gen2 terraform integration (GoogleClou…

3f3ecf0

…dPlatform#5670)

betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022

Adding initial support for GCF Gen2 terraform integration (GoogleClou…

0dcb5e6

…dPlatform#5670)

	references: !ruby/object:Api::Resource::ReferenceLinks
	guides:
	'Automating builds using build triggers': 'https://cloud.google.com/cloud-build/docs/running-builds/automate-builds'
	api: 'https://cloud.google.com/cloud-build/docs/api/reference/rest/v1/projects.triggers'

	id_format: 'projects/{{project}}/locations/{{region}}/functions/{{cloud_function}}'
	id_format: 'projects/{{project}}/locations/{{region}}/functions/{{name}}'

Adding initial support for GCF Gen2 terraform integration #5670

Adding initial support for GCF Gen2 terraform integration #5670

Conversation

k-ezis commented Feb 1, 2022 • edited by c2thorn Loading

modular-magician commented Feb 1, 2022

modular-magician commented Feb 1, 2022

modular-magician commented Feb 1, 2022

Diff report:

modular-magician commented Feb 1, 2022

rileykarson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Feb 4, 2022

modular-magician commented Feb 4, 2022

Diff report:

modular-magician commented Feb 4, 2022

modular-magician commented Feb 4, 2022

Diff report:

modular-magician commented Feb 4, 2022

modular-magician commented Feb 17, 2022

modular-magician commented Feb 17, 2022

Diff report:

modular-magician commented Feb 17, 2022

modular-magician commented Feb 18, 2022

Diff report:

modular-magician commented Feb 18, 2022

Diff report:

modular-magician commented Feb 18, 2022

modular-magician commented Feb 18, 2022

Diff report:

modular-magician commented Feb 18, 2022

modular-magician commented Feb 18, 2022

rileykarson commented Feb 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Mar 1, 2022

Diff report:

c2thorn commented Mar 1, 2022

k-ezis commented Mar 1, 2022

modular-magician commented Mar 1, 2022

Diff report:

c2thorn commented Mar 1, 2022

c2thorn commented Mar 1, 2022

modular-magician commented Mar 1, 2022

Diff report:

modular-magician commented Mar 1, 2022

Diff report:

c2thorn commented Mar 1, 2022

modular-magician commented Mar 1, 2022

Diff report:

modular-magician commented Mar 1, 2022

Diff report:

c2thorn commented Mar 1, 2022

modular-magician commented Mar 1, 2022

Diff report:

modular-magician commented Mar 1, 2022

Diff report:

c2thorn left a comment

Choose a reason for hiding this comment

k-ezis commented Feb 1, 2022 •

edited by c2thorn

Loading