Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi_cluster_routing_cluster_ids #5687

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Feb 7, 2022

Fixes hashicorp/terraform-provider-google#11005

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: added `multi_cluster_routing_cluster_ids` fields to `google_bigtable_app_profile`

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 195 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 195 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 195 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 195 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccBigtableAppProfile_multiClusterIds

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleFolders_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated|TestAccComputeBackendServiceIamMemberGenerated|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated_withCondition|TestAccComputeBackendServiceIamMemberGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_spot|TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccComputeInstanceTemplate_nictype_update|TestAccComputeInstance_scheduling|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstanceConfidentialInstanceConfigMain|TestAccComputeInstance_spotVM|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_bfd|TestAccComputeRouterInterface_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioning|TestAccFolderIamAuditConfig_basic|TestAccFolderIamAuditConfig_update|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamAuditConfig_addFirstExemptMember|TestAccFolderIamAuditConfig_updateNoExemptMembers|TestAccFolderIamBinding_basic|TestAccFolderIamBinding_update|TestAccFolderIamMember_basic|TestAccStorageTransferJob_posixSource|TestAccStorageTransferJob_posixSink You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=254266

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 199 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 199 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccBigtableAppProfile_multiClusterIds

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFolderIamAuditConfig_addFirstExemptMember|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamBinding_basic|TestAccFolderIamMember_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=254806

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccDataSourceGoogleFolder_lookupOrganization|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccApigeeEnvironmentIamBindingGenerated|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccFolderIamMember_basic|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator Please fix these to complete your PR

@megan07 megan07 requested a review from ScottSuarez February 10, 2022 13:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 201 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 201 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccBigtableAppProfile_multiClusterIds

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamMember_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=255308

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccFolderIamMember_basic|TestAccComputeInstance_guestAccelerator|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeInstance_guestAcceleratorSkip Please fix these to complete your PR

@ScottSuarez
Copy link
Contributor

Looks like this test skips the vcrs, is it passing locally for you ?

@megan07
Copy link
Contributor Author

megan07 commented Feb 11, 2022

I just added a new test and some more code to make it updateable from single to multi and vice versa, but yea, everything is passing locally.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 304 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 304 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccBigtableAppProfile_multiClusterIds
  • TestAccBigtableAppProfile_updateSingleToMulti

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=255910

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccCloudbuildWorkerPool_basic Please fix these to complete your PR

lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
* add

* fix bigtable interface error

* fix lint error

* make it updateable for single to/from multi
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
* add

* fix bigtable interface error

* fix lint error

* make it updateable for single to/from multi
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* add

* fix bigtable interface error

* fix lint error

* make it updateable for single to/from multi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for restricted group routing, routing mode updates to google_bigtable_app_profile
3 participants