-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add included_cookie_names to cache_key_policy #5781
Add included_cookie_names to cache_key_policy #5781
Conversation
The GCP EdgeCacheService resource now has the ability to include cookies in cache keys. This commit updates the cache_key_policy configuration of the google_network_services_edge_cache_service resource to support the included_cookie_names configuration option. I tested this with: ``` make testacc TEST=./google TESTARGS='-run=TestAccNetworkServicesEdgeCacheService_.*AdvancedExample' ``` This is part of [hashicorp/terraform-provider-google/GoogleCloudPlatform#10722](/hashicorp/terraform-provider-google/issues/10722). Signed-off-by: Justin Mazzola Paluska <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 47 insertions(+)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 47 insertions(+)) |
VCR timed out due to global queue, running manually: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/264767?buildTab=overview (That's access restricted, you won't be able to access it. Sorry!) |
Hi! Is there anything that I need to do to get the VCR tests to run again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got back to the email I snoozed for this- the test passed, LGTM
The GCP EdgeCacheService resource now has the ability to include cookies in cache keys. This commit updates the
cache_key_policy
configuration of thegoogle_network_services_edge_cache_service
resource to support the
included_cookie_names
configuration option.I tested this with:
This is part of hashicorp/terraform-provider-google/#10722.
Signed-off-by: Justin Mazzola Paluska [email protected]
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)