Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add included_cookie_names to cache_key_policy #5781

Merged

Conversation

justin-mp
Copy link
Contributor

@justin-mp justin-mp commented Mar 3, 2022

The GCP EdgeCacheService resource now has the ability to include cookies in cache keys. This commit updates the cache_key_policy configuration of the google_network_services_edge_cache_service
resource to support the included_cookie_names configuration option.

I tested this with:

make testacc TEST=./google TESTARGS='-run=TestAccNetworkServicesEdgeCacheService_.*AdvancedExample'

This is part of hashicorp/terraform-provider-google/#10722.

Signed-off-by: Justin Mazzola Paluska [email protected]

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

networkservices: added `included_cookie_names` to cache key policy configuration

The GCP EdgeCacheService resource now has the ability to include
cookies in cache keys.  This commit updates the cache_key_policy
configuration of the google_network_services_edge_cache_service
resource to support the included_cookie_names configuration option.

I tested this with:
```
make testacc TEST=./google TESTARGS='-run=TestAccNetworkServicesEdgeCacheService_.*AdvancedExample'
```

This is part of
[hashicorp/terraform-provider-google/GoogleCloudPlatform#10722](/hashicorp/terraform-provider-google/issues/10722).

Signed-off-by: Justin Mazzola Paluska <[email protected]>
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 47 insertions(+))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 47 insertions(+))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

@rileykarson
Copy link
Member

VCR timed out due to global queue, running manually: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/264767?buildTab=overview

(That's access restricted, you won't be able to access it. Sorry!)

@justin-mp
Copy link
Contributor Author

Hi! Is there anything that I need to do to get the VCR tests to run again?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got back to the email I snoozed for this- the test passed, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants