Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google_cloudfunctions2_function_iam_member #6100

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 2, 2022

fixes hashicorp/terraform-provider-google#11792

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloudfunctions2_function_iam_binding`
`google_cloudfunctions2_function_iam_member`
`google_cloudfunctions2_function_iam_policy`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 159 insertions(+))
Terraform Beta: Diff ( 6 files changed, 749 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2035
Passed tests 1803
Skipped tests: 226
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccCloudfunctions2functionIamMemberGenerated|TestAccCloudfunctions2functionIamPolicyGenerated|TestAccCloudfunctions2functionIamBindingGenerated

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudfunctions2functionIamBindingGenerated[view]
TestAccCloudfunctions2functionIamPolicyGenerated[view]
TestAccCloudfunctions2functionIamMemberGenerated[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withNotificationConfig[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@megan07 megan07 requested a review from slevenick June 3, 2022 13:37
@@ -0,0 +1,2 @@
cloud_function = google_cloudfunctions2_function.%{primary_resource_id}.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this rather than having the location be pulled from the resource's ID automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, for some reason it was reading us-central1-a rather than us-central1 (I assume from GOOGLE_ZONE). if you have thoughts on that, I'd be happy change it, but I wasn't able to find a different way around it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh... During the setup or during the import step? That's unusual, but I could see it happening

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During setup

@slevenick slevenick self-requested a review June 8, 2022 15:07
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 159 insertions(+))
Terraform Beta: Diff ( 6 files changed, 749 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2043
Passed tests 1815
Skipped tests: 226
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@tony-kerz
Copy link

thanks so much @megan07 for working on this!

can you help me understand how to figure out when it will make it into a release?

@megan07
Copy link
Contributor Author

megan07 commented Jun 10, 2022

@tony-kerz you're very welcome! it looks like it didn't quite make the next release cut, so you can expect it in 4.26.0 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloudfunctions_function_iam_member not working with cloudfunctions2...?
4 participants