-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add google_cloudfunctions2_function_iam_member #6100
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 159 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccCloudfunctions2functionIamMemberGenerated|TestAccCloudfunctions2functionIamPolicyGenerated|TestAccCloudfunctions2functionIamBindingGenerated |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
@@ -0,0 +1,2 @@ | |||
cloud_function = google_cloudfunctions2_function.%{primary_resource_id}.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this rather than having the location be pulled from the resource's ID automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, for some reason it was reading us-central1-a
rather than us-central1
(I assume from GOOGLE_ZONE
). if you have thoughts on that, I'd be happy change it, but I wasn't able to find a different way around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh... During the setup or during the import step? That's unusual, but I could see it happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During setup
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 159 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons |
thanks so much @megan07 for working on this! can you help me understand how to figure out when it will make it into a release? |
@tony-kerz you're very welcome! it looks like it didn't quite make the next release cut, so you can expect it in |
fixes hashicorp/terraform-provider-google#11792
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)