Revert "Cloud NAT Rules and Configurable TCP Time Wait"

[shuyama1]

Reverts #6221

Looks like tests failed in some of our nightly runs with error:

provider_test.go:309: Step 3/4 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_compute_router_nat.foobar will be updated in-place
~ resource "google_compute_router_nat" "foobar" {
id                                  = "ci-test-project-188019/us-central1/tf-test-router-nat-kal6esk7c1/tf-test-router-nat-kal6esk7c1"
name                                = "tf-test-router-nat-kal6esk7c1"
# (16 unchanged attributes hidden)
~ rules {
~ match       = "inIpRange(destination.ip, '3.3.0.0/16') || inIpRange(destination.ip, '4.4.0.0/16')" -> "inIpRange(destination.ip, '1.1.0.0/16') || inIpRange(destination.ip, '5.5.0.0/16')"
~ rule_number = 2 -> 1
~ action {
~ source_nat_active_ips = [
- "https://www.googleapis.com/compute/v1/projects/ci-test-project-188019/regions/us-central1/addresses/tf-test-router-nat-kal6esk7c1-addr-3",
+ "projects/ci-test-project-188019/regions/us-central1/addresses/tf-test-router-nat-kal6esk7c1-addr-2",
]
# (1 unchanged attribute hidden)
}
}
~ rules {
~ match       = "inIpRange(destination.ip, '1.1.0.0/16') || inIpRange(destination.ip, '5.5.0.0/16')" -> "inIpRange(destination.ip, '3.3.0.0/16') || inIpRange(destination.ip, '4.4.0.0/16')"
~ rule_number = 1 -> 2
~ action {
~ source_nat_active_ips = [
- "https://www.googleapis.com/compute/v1/projects/ci-test-project-188019/regions/us-central1/addresses/tf-test-router-nat-kal6esk7c1-addr-2",
+ "projects/ci-test-project-188019/regions/us-central1/addresses/tf-test-router-nat-kal6esk7c1-addr-3",
]
+ source_nat_drain_ips  = []
}
}
}
Plan: 0 to add, 1 to change, 0 to destroy.

[modular-magician]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

[slevenick]

Looks like a list ordering issue? Probably can be fixed by implementing rules as a set?

Wonder why this passed in VCR, does it fail randomly or every time?

[shuyama1]

Looks like a list ordering issue? Probably can be fixed by implementing rules as a set?

yup, looks like an ordering issue.

Wonder why this passed in VCR, does it fail randomly or every time?

It only fails randomly and passed in VCR.

[slevenick]

It only fails randomly and passed in VCR.

Bummer, that's hard to catch!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 748 deletions(-))
Terraform Beta: Diff ( 3 files changed, 553 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[shuyama1]

It only fails randomly and passed in VCR.

Bummer, that's hard to catch!

I should have checked more carefully when I was reviewing the PR :(

[modular-magician]

Tests analytics

Total tests: 2120
Passed tests 1880
Skipped tests: 226
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_basic|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeRouterNat_removeLogConfig[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRouterNat_withPortAllocationMethods[view]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[view]
TestAccComputeRouterNat_update[view]
TestAccComputeRouterNat_basic[view]

Tests failed during RECORDING mode:
TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view]
TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[view]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test