-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added datasource files for cloudfunctions2_function #6523
Added datasource files for cloudfunctions2_function #6523
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 328 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccDataSourceGoogleCloudFunctions2Function_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
@rileykarson Can you please review this PR? |
mmv1/templates/terraform/custom_flatten/cloudfunctions2_function_source_bucket.go.erb
Show resolved
Hide resolved
mmv1/templates/terraform/custom_flatten/cloudfunctions2_function_source_bucket.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/data_sources/data_source_google_cloudfunctions2_function.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/data_source_google_cloudfunctions2_function_test.go
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/d/cloudfunctions2_function.html.markdown
Show resolved
Hide resolved
Oh, see https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md for details on formatting the release notes for your change as well! |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 163 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineStandardAppVersion_update|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 167 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccDataSourceGoogleServiceAccountJwt |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 177 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstance_soleTenantNodeAffinities|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) |
…udfunctions2_function
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
@rileykarson I've made the changes as suggested. Can you please review these changes? |
@rileykarson Could you please merge this PR? |
Created Datasource file and corresponding Test as well as Web documentation for google_cloudfunctions2_function.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)