Firebase Hosting site Terraform provider #6598

rainshen49 · 2022-09-23T15:03:11Z

Adds provider support for Firebase Hosting Sites API, along with handwritten update test

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

`google_firebase_hosting_site`

modular-magician · 2022-09-23T15:03:28Z

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician · 2022-09-23T15:04:14Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

rainshen49 · 2022-09-23T15:06:55Z

@tylerg-dev @mraouffouad

modular-magician · 2022-09-23T15:24:18Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 108 insertions(+))
Terraform Beta: Diff ( 6 files changed, 637 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

rainshen49 · 2022-09-23T15:29:47Z

It's also not supposed to generate GA docs. What other changes do I need other than min_version: beta?

modular-magician · 2022-09-23T16:32:54Z

Tests analytics

Total tests: 2179
Passed tests 1937
Skipped tests: 238
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseHostingSite_firebasehostingSiteBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-23T16:38:17Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/templates/terraform/examples/firebasehosting_site_basic.tf.erb

modular-magician · 2022-09-26T16:46:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 114 insertions(+))
Terraform Beta: Diff ( 6 files changed, 649 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

melinath · 2022-09-26T17:00:15Z

It's also not supposed to generate GA docs. What other changes do I need other than min_version: beta?

the docs for beta resources and fields also show up in the GA docs, but marked as "beta". This is WAI, no need to change anything. :-)

melinath

leaving a review to remove from my queue - please re-request review when it's ready.

modular-magician · 2022-09-26T17:53:37Z

Tests analytics

Total tests: 2182
Passed tests 1942
Skipped tests: 238
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseHostingSite_firebasehostingSiteBasicExample

modular-magician · 2022-09-26T17:53:58Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/firebasehosting/api.yaml

mmv1/products/firebasehosting/terraform.yaml

modular-magician · 2022-09-27T21:17:57Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 114 insertions(+))
Terraform Beta: Diff ( 6 files changed, 650 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-27T21:35:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 118 insertions(+))
Terraform Beta: Diff ( 6 files changed, 666 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-27T22:32:38Z

Tests analytics

Total tests: 2183
Passed tests 1942
Skipped tests: 238
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseHostingSite_firebasehostingSiteBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-27T22:33:25Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/firebasehosting/terraform.yaml

modular-magician · 2022-09-29T14:47:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 118 insertions(+))
Terraform Beta: Diff ( 6 files changed, 666 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-29T15:55:26Z

Tests analytics

Total tests: 2193
Passed tests 1940
Skipped tests: 240
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseHostingSite_firebasehostingSiteBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_update

melinath

Please address the above change request before re-requesting review.

modular-magician · 2022-09-29T16:32:01Z

Tests passed during RECORDING mode:
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-02T15:48:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 130 insertions(+))
Terraform Beta: Diff ( 7 files changed, 805 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-02T16:26:15Z

Tests analytics

Total tests: 2216
Passed tests 1976
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-02T16:26:40Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-11-07T15:46:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 130 insertions(+))
Terraform Beta: Diff ( 7 files changed, 805 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-07T16:23:51Z

Tests analytics

Total tests: 2219
Passed tests 1979
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-07T16:24:17Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

melinath · 2022-11-07T18:29:57Z

manual test run out of an abundance of caution: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/351165

* Firebase Hosting site Terraform provider * Add sweeper to Firebase Hosting Site * Add a basic hosting site without app * Move app_id to test_vars_overrides to avoid adding random_suffix * Add defaultUrl. Shorten base_url. Add sites/site-id import * Create new web app as part of hosting site test * Fix tab vs spaces * Separate basic and full test for firebasehosting * Add update test for google_firebase_hosting_site * Use immediate delete for test web app * Use deletion_policy = DELETE for handwritten update test * Address feedack on site_id name * Use specific Firebase Hosting docs

modular-magician requested a review from melinath September 23, 2022 15:04

rainshen49 force-pushed the main branch from b196277 to 4723a56 Compare September 23, 2022 15:14

rainshen49 marked this pull request as ready for review September 23, 2022 17:16

tylerg-dev reviewed Sep 26, 2022

View reviewed changes

mmv1/templates/terraform/examples/firebasehosting_site_basic.tf.erb Outdated Show resolved Hide resolved

melinath reviewed Sep 26, 2022

View reviewed changes

rainshen49 requested a review from melinath September 26, 2022 17:18

tylerg-dev reviewed Sep 27, 2022

View reviewed changes

mmv1/products/firebasehosting/api.yaml Outdated Show resolved Hide resolved

tylerg-dev reviewed Sep 27, 2022

View reviewed changes

mmv1/products/firebasehosting/api.yaml Outdated Show resolved Hide resolved

tylerg-dev reviewed Sep 27, 2022

View reviewed changes

mmv1/products/firebasehosting/terraform.yaml Outdated Show resolved Hide resolved

melinath requested changes Sep 27, 2022

View reviewed changes

mmv1/products/firebasehosting/terraform.yaml Outdated Show resolved Hide resolved

rainshen49 requested a review from melinath September 29, 2022 14:24

melinath requested changes Sep 29, 2022

View reviewed changes

rainshen49 added 13 commits November 7, 2022 10:32

Firebase Hosting site Terraform provider

c5cd6a8

Add sweeper to Firebase Hosting Site

b9f5754

Add a basic hosting site without app

1c42818

Move app_id to test_vars_overrides to avoid adding random_suffix

82569ae

Add defaultUrl. Shorten base_url. Add sites/site-id import

ddf69af

Create new web app as part of hosting site test

590e28c

Fix tab vs spaces

9de97ca

Separate basic and full test for firebasehosting

ed1369a

Add update test for google_firebase_hosting_site

0435f6b

Use immediate delete for test web app

4d6d3bd

Use deletion_policy = DELETE for handwritten update test

3a747ed

Address feedack on site_id name

e89f01f

Use specific Firebase Hosting docs

80fade4

rainshen49 force-pushed the main branch from 7c4e85b to 80fade4 Compare November 7, 2022 15:32

rainshen49 mentioned this pull request Nov 7, 2022

Support Firebase Hosting hashicorp/terraform-provider-google#12955

Open

This was referenced Nov 7, 2022

Firebase hosting siteconfig #6790

Closed

Firebase hosting channel #6791

Merged

melinath approved these changes Nov 7, 2022

View reviewed changes

melinath merged commit b2a5ec8 into GoogleCloudPlatform:main Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firebase Hosting site Terraform provider #6598

Firebase Hosting site Terraform provider #6598

rainshen49 commented Sep 23, 2022 •

edited

Loading

modular-magician commented Sep 23, 2022

modular-magician commented Sep 23, 2022

rainshen49 commented Sep 23, 2022

modular-magician commented Sep 23, 2022

rainshen49 commented Sep 23, 2022

modular-magician commented Sep 23, 2022

modular-magician commented Sep 23, 2022

modular-magician commented Sep 26, 2022

melinath commented Sep 26, 2022

melinath left a comment

modular-magician commented Sep 26, 2022

modular-magician commented Sep 26, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 29, 2022

modular-magician commented Sep 29, 2022

melinath left a comment

modular-magician commented Sep 29, 2022

modular-magician commented Nov 2, 2022

modular-magician commented Nov 2, 2022

modular-magician commented Nov 2, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

melinath commented Nov 7, 2022

Firebase Hosting site Terraform provider #6598

Firebase Hosting site Terraform provider #6598

Conversation

rainshen49 commented Sep 23, 2022 • edited Loading

modular-magician commented Sep 23, 2022

modular-magician commented Sep 23, 2022

rainshen49 commented Sep 23, 2022

modular-magician commented Sep 23, 2022

Diff report:

rainshen49 commented Sep 23, 2022

modular-magician commented Sep 23, 2022

Tests analytics

Action taken

modular-magician commented Sep 23, 2022

modular-magician commented Sep 26, 2022

Diff report:

melinath commented Sep 26, 2022

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 26, 2022

Tests analytics

Action taken

modular-magician commented Sep 26, 2022

modular-magician commented Sep 27, 2022

Diff report:

modular-magician commented Sep 27, 2022

Diff report:

modular-magician commented Sep 27, 2022

Tests analytics

Action taken

modular-magician commented Sep 27, 2022

modular-magician commented Sep 29, 2022

Diff report:

modular-magician commented Sep 29, 2022

Tests analytics

Action taken

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 29, 2022

modular-magician commented Nov 2, 2022

Diff report

modular-magician commented Nov 2, 2022

Tests analytics

Action taken

modular-magician commented Nov 2, 2022

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 7, 2022

Tests analytics

Action taken

modular-magician commented Nov 7, 2022

melinath commented Nov 7, 2022

rainshen49 commented Sep 23, 2022 •

edited

Loading