Added private connectivity field to datastream_connection_profile

[melinath]

Related to hashicorp/terraform-provider-google#10810

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datastream: added `private_connectivity` field to `google_datastream_connection_profile`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2207
Passed tests 1964
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2207
Passed tests 1964
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

test failures look unrelated to me.

[jlowe64]

@melinath thanks for your work on this. I'm subscribing to this to know when it's finished!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 138 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2196
Passed tests 1957
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log