Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): add vertex_ai_index_endpoint for Vertex AI Matching Engine #6873

Merged
merged 17 commits into from
Jun 7, 2023

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Nov 25, 2022

Part of hashicorp/terraform-provider-google#12818
Part of hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertex_ai_index_endpoint

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @roaks3, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 869 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 869 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 103 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2282
Passed tests 2034
Skipped tests: 244
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

All tests passed
View the build log or the debug log for each test

@shotarok shotarok marked this pull request as ready for review November 25, 2022 04:24
@shotarok
Copy link
Contributor Author

@roaks3 All tests passed. When you have time, could you please revive this PR? Thanks

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 869 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 869 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 103 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2298
Passed tests 2049
Skipped tests: 244
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccVertexAIIndex_updated|TestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_vertexAiIndexExample|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccVertexAIIndex_updated[Debug log]
TestAccVertexAIIndex_vertexAiIndexExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccVertexAIIndex_vertexAiIndexStreamingExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@shotarok
Copy link
Contributor Author

/gcbrun

@shotarok
Copy link
Contributor Author

@roaks3 The failed test is not related to the changes in this PR. So could you review this PR? Apart from that, the failed test is what I added in the previous PR. So I'd appreciate it if I could know the error message to fix it in a separate PR 🙏

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, I just wanted to check if there was a reason for leaving deployedIndexes out. Ideally we would probably want to include it within this changeset.

mmv1/products/vertexai/api.yaml Outdated Show resolved Hide resolved
mmv1/products/vertexai/api.yaml Outdated Show resolved Hide resolved
@shotarok shotarok requested a review from roaks3 December 2, 2022 21:35
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding another reviewer for follow-up

@roaks3 roaks3 requested a review from slevenick December 7, 2022 19:19
@shotarok
Copy link
Contributor Author

shotarok commented Dec 8, 2022

@roaks3 Thank you for your reviews!

@slevenick Could you review this PR when you have time? Thanks!

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an update test for this resource? We write handwritten update tests to make sure the resource can be modified in-place correctly and that the fields marked as updatable (in this case it looks like network is updatable?) are actually updatable

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1015 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1015 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 103 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1015 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1015 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 103 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1032 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1032 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 108 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2764
Passed tests 2473
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccVertexAIIndexEndpoint_updated|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccVertexAIIndexEndpoint_updated[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@roaks3
Copy link
Contributor

roaks3 commented Jun 2, 2023

Awesome, this is ready to go!

I checked the CLA issue, and it does appear you'll need to rebase to remove my gmail.com-authored commit (sorry for the inconvenience):

  1. Use git rebase -i.
  2. Type e or edit on the commits you want to update.
  3. For each commit, run: git commit --amend --reset-author and git rebase --continue
  4. A force push to remote branch is required if you have pushed your branch before.

@shotarok shotarok force-pushed the vertex-ai-index-endpoint branch from a9efb02 to 4d707ca Compare June 2, 2023 20:17
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 2, 2023
@shotarok
Copy link
Contributor Author

shotarok commented Jun 2, 2023

@roaks3 Yay, I completed the git-rebase. Could you please approve the workflow again?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1032 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1032 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 108 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 133 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2770
Passed tests 2479
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateSkipCharactersExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample[Debug log]
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate[Debug log]
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateSkipCharactersExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@roaks3
Copy link
Contributor

roaks3 commented Jun 6, 2023

@slevenick this is now blocked on your prior review where changes were requested. It looks good to me, so would you mind clearing your review so we can merge, or giving it another pass?

@slevenick slevenick dismissed their stale review June 6, 2023 17:03

Outdated

@shotarok
Copy link
Contributor Author

shotarok commented Jun 7, 2023

Hello @roaks3, It looks like @slevenick unblocked this PR to merge by removing the past change request. Can we merge this PR with your approval to wrap up?

@roaks3
Copy link
Contributor

roaks3 commented Jun 7, 2023

Thanks for the ping! Yep, we can go ahead and merge. I'm going to wait just a bit as GitHub is having some issues, but once things look stable we can move forward.

@roaks3 roaks3 merged commit 64e19f8 into GoogleCloudPlatform:main Jun 7, 2023
@shotarok
Copy link
Contributor Author

shotarok commented Jun 7, 2023

Thank you all for your kind support and feedback!

@shotarok shotarok deleted the vertex-ai-index-endpoint branch June 7, 2023 20:16
codding-buddha pushed a commit to codding-buddha/magic-modules that referenced this pull request Jun 14, 2023
…ngine (GoogleCloudPlatform#6873)

* feat: create vertex_ai_index_endpoint

* fix: remove a white line

* feat: add a comment about deployedIndexes [ci skip]

* feat: add an unit test to check update

* fix: fix the handwritten test name to avoid a conflict

* fix: fix unnecessary code from test

* fix: use immutable instead of input

* refactor: refactor test code with acctest and tpgresource

* test: update network_name to use the unique names

* test: fix an invalid label definition

* feat: increase timeout from 20m to 1h regarding vertex ai index endpoint

* test: increase the timeouts to 120m

* Apply suggestions from code review

* feat: update test and yaml to clarify the fields mutabilities
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…ngine (GoogleCloudPlatform#6873)

* feat: create vertex_ai_index_endpoint

* fix: remove a white line

* feat: add a comment about deployedIndexes [ci skip]

* feat: add an unit test to check update

* fix: fix the handwritten test name to avoid a conflict

* fix: fix unnecessary code from test

* fix: use immutable instead of input

* refactor: refactor test code with acctest and tpgresource

* test: update network_name to use the unique names

* test: fix an invalid label definition

* feat: increase timeout from 20m to 1h regarding vertex ai index endpoint

* test: increase the timeouts to 120m

* Apply suggestions from code review

* feat: update test and yaml to clarify the fields mutabilities
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…ngine (GoogleCloudPlatform#6873)

* feat: create vertex_ai_index_endpoint

* fix: remove a white line

* feat: add a comment about deployedIndexes [ci skip]

* feat: add an unit test to check update

* fix: fix the handwritten test name to avoid a conflict

* fix: fix unnecessary code from test

* fix: use immutable instead of input

* refactor: refactor test code with acctest and tpgresource

* test: update network_name to use the unique names

* test: fix an invalid label definition

* feat: increase timeout from 20m to 1h regarding vertex ai index endpoint

* test: increase the timeouts to 120m

* Apply suggestions from code review

* feat: update test and yaml to clarify the fields mutabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants