Added new contents in rules[].rateLimitOptionsfields for google_compute_security_policy to support Cloud Armor #7132

afpesseti · 2023-01-16T20:34:38Z

API: https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Added new contents in rules[].rateLimitOptionsfields for `google_compute_security_policy` to support Cloud Armor Rate Limit Options (beta)

modular-magician · 2023-01-16T20:35:44Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @zli82016, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-01-16T20:50:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 168 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-16T21:38:30Z

Tests analytics

Total tests: 2420
Passed tests 2166
Skipped tests: 252
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs|TestAccComputeSecurityPolicy_withRateLimitOptions

modular-magician · 2023-01-16T21:39:12Z

Tests passed during RECORDING mode:
TestAccComputeSecurityPolicy_withRateLimitOptions[Debug log]

Tests failed during RECORDING mode:
TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-16T23:29:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 156 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T00:19:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 157 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T01:03:49Z

Tests analytics

Total tests: 2420
Passed tests 2166
Skipped tests: 252
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2023-01-17T01:04:17Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-17T12:48:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field rule.rate_limit_options.enforce_on_key default value changed from ALL to ALL on google_compute_security_policy - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 28 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 157 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T13:20:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 28 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 157 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T14:08:36Z

Tests analytics

Total tests: 2420
Passed tests 2165
Skipped tests: 252
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs|TestAccComputeForwardingRule_update

modular-magician · 2023-01-17T14:10:02Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

zli82016 · 2023-01-17T18:29:44Z

mmv1/third_party/terraform/resources/resource_compute_security_policy.go.erb

+										Type:        schema.TypeList,
+										Description: `Enforce On Key Config of this security policy`,
+										Optional:    true,
+										MaxItems:    3,


Normally, we will leave the validation on server side in case the validation will change, unless the users requested it.

It's an internal Google request to set this new providers. I don't know if a answer your question correctly.

Sorry for the confusion. MaxItems: 3, can be removed from this file. I think API side will have the same validation.

Don't worry :D I already remove, thank you for let me know!

zli82016 · 2023-01-17T20:28:41Z

mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb

@@ -274,6 +274,30 @@ func TestAccComputeSecurityPolicy_withRateLimitWithRedirectOptions(t *testing.T)
 	})
 }

+<% unless version == 'ga' -%>
+func TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs(t *testing.T) {


The test failed. You can check the errr message by clicking "Error Message" next to the failed test.

Hi there!

The test failed because we need to change the enforceOnKey, this provider has "default" value and automatically is inserted on the tests:

The enforceOnKeyConfigs is a new providers that must not has the enforceOnKey in the same script.

Check the image from API:

Check the API doc bellow if you wish:
https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies

We can't remove the default value from enforceOnKey, we are search how we can solved this. When we run the test with enforceOnKey default value on we receive this error:

When we run the test without enforceOnKey default value the test passes.

I tested after removing the Default: "ALL" for the field enforce_on_key in this file and then run the test locally. The test sends the request to API.

Request:

{ "description": "updated description", "name": "tf-test-418rgij846", "rules": [ { "action": "throttle", "description": "default rule", "headerAction": {}, "match": { "config": { "srcIpRanges": [ "*" ] }, "versionedExpr": "SRC_IPS_V1" }, "preview": false, "priority": 2147483647, "rateLimitOptions": { "conformAction": "allow", "exceedAction": "deny(403)", "rateLimitThreshold": { "count": 100, "intervalSec": 60 } } } ] }

Response:

{ "kind": "compute#securityPolicy", "id": "184350908738827980", "creationTimestamp": "2023-01-18T11:27:31.714-08:00", "name": "tf-test-418rgij846", "description": "updated description", "rules": [ { "kind": "compute#securityPolicyRule", "description": "default rule", "priority": 2147483647, "match": { "versionedExpr": "SRC_IPS_V1", "config": { "srcIpRanges": [ "*" ] } }, "action": "throttle", "preview": false, "rateLimitOptions": { "rateLimitThreshold": { "count": 100, "intervalSec": 60 }, "conformAction": "allow", "exceedAction": "deny(403)" }, "headerAction": {} } ], "fingerprint": "mQvRGsyan_U=", "selfLink": "https://www.googleapis.com/compute/v1/projects/local-mediator-361721/global/securityPolicies/tf-test-418rgij846", "type": "CLOUD_ARMOR" }

In the response, I do not see the field enforceOnKey. Does that mean enforceOnKey has the default value ALL for this rule?

Is the response expected from API side?

Hello there!

About your test: yes, you're correct, you locally removed the Default: “ALL” from the enforceOnKey field and the response doesn't show the value, right? This is expected to happen when you make this change.

The default value when inserted in a provider is automatically inserted when you generate a terraform test or a terraform script, that's the purpose of using the Default field.

I looked better about the in terraform-plugin-sdk (the library used to build providers) and the description about what it does when: the attribute Default

// Default indicates a value to set if this attribute is not set in the // configuration. Default cannot be used with DefaultFunc or Required. // Default is only supported if the Type is TypeBool, TypeFloat, TypeInt, // or TypeString. Default cannot be used if the Schema is directly an // implementation of an Elem field of another Schema, such as trying to // set a default value for a TypeList or TypeSet. // // Changing either Default can be a breaking change, especially if the // attribute has ForceNew enabled. If a default needs to change to align // with changing assumptions in an upstream API, then it may be necessary // to also implement resource state upgrade functionality to change the // state to match or update read operation logic to align with the new // default. Default interface{}

Link to the code above.

The enforceOnKeyConfigs is a new attribute and conflicts with enforceOnKey, so only one must be set at a time, as stated in the [Google API documentation (https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies#:~:text=If%20enforceOnKeyConfigs%20is%20specified%2C%20enforceOnKey%20must%20not%20be%20specified):

I double checked and have created a test with enforceOnKeyConfigs fields,and tested locally with enforceOnKey Default: “ALL” inserted and I got an error with the message: “Only one of enforceOnKey and enforceOnKeyConfigs can be specified”. When I removed the Default: “ALL” from enforceOnKey and ran the test again, it passed successfully.

(Conflict error between enforceOnKey and enforceOnKeyConfigs when default is inserted)

You can check on SDK documentation about the enforceOnKeyConfigs here

I tried to remove the enforceOnKey Default: “ALL” field, but during the PR I got the breaking change, I can’t remove this.

So, our understanding is that the magic module pipeline runs some additional tests, and for some reason it doesn’t handle this conflicting case.

Currently, there is only one test that tests enforceOnKey.

To test the enforceOnKeyConfigs, we cannot use enforceOnKey, but it sounds like a magic-module pipeline does some additional tests that automatically insert an enforceOnKey, enforcing that when we run locally the test, it PASS with success.

We are kind of lost here. Where is the issue? Can you help us with this?

Config: https://paste.googleplex.com/4578722240790528
Terraform plan output: https://paste.googleplex.com/6415383668981760

@afpesseti , after talked with the team, instead of removing the default value for the field enforceOnKey, we are going to do the following:

Add "" to the list of allowed values for the field enforceOnKey to allow the user to specify "" to avoid conflict with the new field. https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/resources/resource_compute_security_policy.go.erb#L265

In the tests, when testing with the new field enforceOnKeyConfigs, in the config add

enforce_on_key = ""

to avoid conflict.

In the doc of the new field enforceOnKeyConfigs, add a note that to set the field, enforce_on_key needs to be empty string.
Example:

magic-modules/mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown

Line 74 in 62a62f2

**Note:** If you want to update this value (resize the VM) after initial creation, you must set [`allow_stopping_for_update`](#allow_stopping_for_update) to `true`.

Hello there! Thank you both for the help! About the new steps, just so there are no loose ends: are they going to be done by your end? Should we also do any of the listed steps on our end?
Just double checking! :D

Hello, @afpesseti , can you please do the listed steps? If you need any help, feel free to let us know. Thanks.

Hi There! Steps done :D Thank you so much for help us ❤️

zli82016 · 2023-01-17T20:29:26Z

mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb

+
+			enforce_on_key_configs {
+				enforce_on_key_type = "HTTP_HEADER"
+                enforce_on_key_name = "user-agent"


weird indentation.

We'll adjust this. On editor is very different, we only see this weird indentation after we push the code. But we'll adjust and run again. Thank you for let me know :D

zli82016 · 2023-01-17T20:34:14Z

mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb

+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckComputeSecurityPolicyDestroyProducer(t),
+		Steps: []resource.TestStep{


Can more tests be added to update and remove enforce_on_key_configs?
Example: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb#L80-L116

Hello! I remade the test, I only put the update step, because the remove test got this error:

I don't know if this error is internal or external.

I don't see any different between testAccComputeSecurityPolicy_withRateLimitOptions_withEnforceOnKeyConfigs_withRedirectOptionsUpdate and testAccComputeSecurityPolicy_withRateLimitOptions_withEnforceOnKeyConfigs.

Also, I cannot tell what happened for the error of removal, as I cannot see the removal test.

Hello there! Sorry for delay.

I was trying to create an enforceOnKeyConfig update and removal test, but it didn't work, every removal or update failed. So, I had an idea: I created two tests, one with only one enforceOnKeyConfig item using redirect options and other with multiple enforceOnKeyConfig items. I took as an example the TestAccComputeSecurityPolicy_withRateLimitOptions, there are two test with enforceOnKey with two examples, but there is no update or removal test.

zli82016 · 2023-01-17T20:38:41Z

mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown


 * `enforce_on_key_name` - (Optional) Rate limit key name applicable only for the following key types: HTTP_HEADER -- Name of the HTTP header whose value is taken as the key value. HTTP_COOKIE -- Name of the HTTP cookie whose value is taken as the key value.

+* `enforce_on_key_configs` - (Optional) If specified, any combination of values of enforce_on_key_type/enforce_on_key_name is treated as the key on which ratelimit threshold/action is enforced. You can specify up to 3 enforce_on_key_configs. If enforce_on_key_configs is specified, enforce_on_key must not be specified. Structure is [documented below](#nested_enforce_on_key_configs).


As enforce_on_key_configs is only available in Beta API, can you please add Beta after Optional?

Please check the doc for the field preconfigured_waf_config in the same file.
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown?plain=1#L188

Thanks for warning about this, fixed.

zli82016 · 2023-01-17T20:41:32Z

@afpesseti , can you please change the title and release note for this PR? The current title and release note are not related.

Also, is there an open issue in github or buganizer for this PR? If is, please add to the description of this PR.

modular-magician · 2023-01-17T21:04:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 28 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 157 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T21:48:30Z

Tests analytics

Total tests: 2421
Passed tests 2168
Skipped tests: 252
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs

modular-magician · 2023-02-02T18:12:59Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeSecurityPolicy_withRateLimitOption_withMultipleEnforceOnKeyConfigs[Debug log]
TestAccComputeSecurityPolicy_withRateLimit_withEnforceOnKeyConfigs[Debug log]

All tests passed
View the build log or the debug log for each test

zli82016

LGTM.

zli82016 · 2023-02-02T18:29:37Z

Waiting for the review from @ScottSuarez

ScottSuarez

Asking for some documentation changes. Looks good otherwise.

mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown

mmv1/third_party/terraform/resources/resource_compute_security_policy.go.erb

…icy.html.markdown Co-authored-by: Scott Suarez <[email protected]>

modular-magician · 2023-02-06T18:06:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 227 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-06T18:57:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 112 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 309 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-06T19:39:15Z

Tests analytics

Total tests: 2455
Passed tests 2192
Skipped tests: 255
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataSourceDnsRecordSet_basic|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

modular-magician · 2023-02-06T19:58:16Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccBillingSubaccount_basic[Debug log]
TestAccBillingSubaccount_renameOnDestroy[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-02-07T15:19:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 72 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 269 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-07T16:01:28Z

Tests analytics

Total tests: 2456
Passed tests 2197
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFrameworkProviderMeta_setModuleName|TestAccRegionInstanceGroupManager_stateful|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic

modular-magician · 2023-02-07T16:05:21Z

Tests passed during RECORDING mode:
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Update brach

zli82016 · 2023-02-09T16:47:09Z

/gcbrun

modular-magician · 2023-02-09T17:02:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 72 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 269 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-09T17:44:03Z

Tests analytics

Total tests: 2468
Passed tests 2207
Skipped tests: 256
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRouterNat_update|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsManagedZone_basic|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic

modular-magician · 2023-02-09T17:55:51Z

Tests passed during RECORDING mode:
TestAccComputeRouterNat_update[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

ScottSuarez

looks good !

…te_security_policy to support Cloud Armor (GoogleCloudPlatform#7132) Co-authored-by: Scott Suarez <[email protected]>

feat: add new providers and create test

15be16b

modular-magician requested a review from zli82016 January 16, 2023 20:35

afpesseti added 2 commits January 16, 2023 20:04

fix: add new options on enum

a5f9cfd

test: remake a test

23d511f

fix: remove default from enforce_on_key_configs

e7eecc3

afpesseti added 2 commits January 17, 2023 09:24

feat: remove default from enforce_on_key

a62031d

fix: remove block

ec79d09

fix: go back with default value

c5feb98

zli82016 reviewed Jan 17, 2023

View reviewed changes

fix: adjust indentation

3d7e861

modular-magician requested a review from zli82016 January 17, 2023 20:49

zli82016 approved these changes Feb 2, 2023

View reviewed changes

ScottSuarez requested changes Feb 3, 2023

View reviewed changes

afpesseti and others added 2 commits February 6, 2023 14:50

Update mmv1/third_party/terraform/website/docs/r/compute_security_pol…

b20f611

…icy.html.markdown Co-authored-by: Scott Suarez <[email protected]>

Update mmv1/third_party/terraform/website/docs/r/compute_security_pol…

d1c13c9

…icy.html.markdown Co-authored-by: Scott Suarez <[email protected]>

modular-magician requested review from ScottSuarez and zli82016 February 6, 2023 17:52

add an example with and without enforceOnKey code

24acf91

add an example usage with enforceOnKey

bed8c0e

afpesseti added 2 commits February 9, 2023 10:25

Merge pull request #1 from fernandoleonem/main

410374f

Update brach

update markdown

7bbc1c6

ScottSuarez approved these changes Feb 10, 2023

View reviewed changes

ScottSuarez merged commit 66b3b6f into GoogleCloudPlatform:main Feb 10, 2023

zli82016 mentioned this pull request Mar 2, 2023

Remove the default value for the field rule.rate_limit_options.enforce_on_key on resource google_compute_security_policy hashicorp/terraform-provider-google#13883

Closed


		* `enforce_on_key_name` - (Optional) Rate limit key name applicable only for the following key types: HTTP_HEADER -- Name of the HTTP header whose value is taken as the key value. HTTP_COOKIE -- Name of the HTTP cookie whose value is taken as the key value.

		* `enforce_on_key_configs` - (Optional) If specified, any combination of values of enforce_on_key_type/enforce_on_key_name is treated as the key on which ratelimit threshold/action is enforced. You can specify up to 3 enforce_on_key_configs. If enforce_on_key_configs is specified, enforce_on_key must not be specified. Structure is [documented below](#nested_enforce_on_key_configs).

Added new contents in rules[].rateLimitOptionsfields for google_compute_security_policy to support Cloud Armor #7132

Added new contents in rules[].rateLimitOptionsfields for google_compute_security_policy to support Cloud Armor #7132

Conversation

afpesseti commented Jan 16, 2023 • edited Loading

modular-magician commented Jan 16, 2023

modular-magician commented Jan 16, 2023

Diff report

modular-magician commented Jan 16, 2023

Tests analytics

Action taken

modular-magician commented Jan 16, 2023

modular-magician commented Jan 16, 2023

Diff report

modular-magician commented Jan 17, 2023

Diff report

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

modular-magician commented Jan 17, 2023

modular-magician commented Jan 17, 2023

Breaking Change(s) Detected

Diff report

modular-magician commented Jan 17, 2023

Diff report

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

modular-magician commented Jan 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zli82016 Jan 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afpesseti Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zli82016 Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zli82016 Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zli82016 commented Jan 17, 2023

modular-magician commented Jan 17, 2023

Diff report

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

modular-magician commented Feb 2, 2023

zli82016 left a comment

Choose a reason for hiding this comment

zli82016 commented Feb 2, 2023

ScottSuarez left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 6, 2023

Diff report

modular-magician commented Feb 6, 2023

Diff report

modular-magician commented Feb 6, 2023

Tests analytics

Action taken

modular-magician commented Feb 6, 2023

modular-magician commented Feb 7, 2023

Diff report

modular-magician commented Feb 7, 2023

Tests analytics

Action taken

modular-magician commented Feb 7, 2023

afpesseti commented Jan 16, 2023 •

edited

Loading

zli82016 Jan 18, 2023 •

edited

Loading

afpesseti Jan 20, 2023 •

edited

Loading

zli82016 Feb 1, 2023 •

edited

Loading

zli82016 Jan 17, 2023 •

edited

Loading