Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bigquery data masking v1 api options #7406

Conversation

rariyama
Copy link
Contributor

@rariyama rariyama commented Mar 6, 2023

This PR is following up hashicorp/terraform-provider-google#13867
It'll be possible to use additional masking policies if this API version is upgraded.
https://cloud.google.com/bigquery/docs/reference/bigquerydatapolicy/rest/v1/projects.locations.dataPolicies#predefinedexpression

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatapolicy: updated api version from v1beta1 to v1 and made it possible to use additional data policies.

@rariyama rariyama requested a review from a team as a code owner March 6, 2023 09:42
@rariyama rariyama requested review from c2thorn and removed request for a team March 6, 2023 09:42
@rariyama rariyama force-pushed the support_for_bigquery_data_masking_v1_api_options branch from 33ddba2 to 87af0b1 Compare March 6, 2023 10:46
fix test resource

fix location fmt

fix fmt

fix fmt
@rariyama rariyama force-pushed the support_for_bigquery_data_masking_v1_api_options branch from 87af0b1 to d53dd29 Compare March 6, 2023 13:24
@c2thorn
Copy link
Member

c2thorn commented Mar 6, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 18 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2487
Passed tests 2223
Skipped tests: 258
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants