Adding IAM resources for Dataplex Lake, Zone and Asset #7436

dbjnbnrj · 2023-03-09T23:11:24Z

Adding get/setIAMPolicy support for Dataplex Lake, Zone and Asset
Lake, Zone and Asset resources were generated via DCL. Followed guide https://googlecloudplatform.github.io/magic-modules/docs/how-to/add-mmv1-iam/#adding-iam-support-to-nonexistent-resources to add the IAM resources.
(part of hashicorp/terraform-provider-google#11648)

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_dataplex_lake_iam_*`

`google_dataplex_zone_iam_*`

`google_dataplex_asset_iam_*`

shuyama1 · 2023-03-09T23:14:57Z

@dbjnbnrj Thanks for making the PR. Would you mind rebasing your PR to kick in a recent CI change? Thanks

shuyama1 · 2023-03-10T22:26:33Z

/gcbrun

modular-magician · 2023-03-10T22:44:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 12 files changed, 2311 insertions(+), 2 deletions(-))
TF Validator: Diff ( 11 files changed, 1109 insertions(+), 3 deletions(-))

modular-magician · 2023-03-10T23:35:05Z

Tests analytics

Total tests: 2505
Passed tests 2220
Skipped tests: 262
Affected tests: 23

Action taken

Found 23 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate|TestAccDataplexZoneIamPolicyGenerated|TestAccDataplexLakeIamBindingGenerated|TestAccDataplexZoneIamMemberGenerated|TestAccDataplexZoneIamBindingGenerated|TestAccDataplexLakeIamPolicyGenerated|TestAccDataplexAssetIamPolicyGenerated|TestAccDataplexLakeIamMemberGenerated|TestAccDataplexAssetIamMemberGenerated|TestAccDataplexAssetIamBindingGenerated|TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificate_privatecaCertificateUpdate|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificateAuthority_rootCaManageDesiredState|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCaPool_updateCaOption|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-10T23:41:18Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate[Debug log]
TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateUpdate[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample[Debug log]
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateCsrExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateConfigExample[Debug log]
TestAccPrivatecaCertificateAuthority_rootCaManageDesiredState[Debug log]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample[Debug log]
TestAccPrivatecaCaPool_updateCaOption[Debug log]
TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline[Debug log]
TestAccPrivatecaCaPool_privatecaCapoolUpdate[Debug log]

Tests failed during RECORDING mode:
TestAccDataplexZoneIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexLakeIamBindingGenerated[Error message] [Debug log]
TestAccDataplexZoneIamMemberGenerated[Error message] [Debug log]
TestAccDataplexZoneIamBindingGenerated[Error message] [Debug log]
TestAccDataplexLakeIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexAssetIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexLakeIamMemberGenerated[Error message] [Debug log]
TestAccDataplexAssetIamMemberGenerated[Error message] [Debug log]
TestAccDataplexAssetIamBindingGenerated[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

dbjnbnrj · 2023-03-11T16:42:55Z

Hi @shuyama1,

Can you help me debug the VCRTest run? I'm unusure what the root cause is and my local runs have been successful -

        Error: Error setting IAM policy for dataplex zone "projects/ci-test-project-188019/locations/us-central1/lakes/tf-test-lakeesn7g39rdj/zones/tf-test-zoneesn7g39rdj": Post "projects/ci-test-project-188019/locations/us-central1/lakes/tf-test-lakeesn7g39rdj/zones/tf-test-zoneesn7g39rdj:setIamPolicy?alt=json": unsupported protocol scheme ""

shuyama1

Would you mind splitting the api.yaml file into individual file for each resource. Sorry we recently did the file split and now product level file api.yaml should no longer be added

tpgtools/overrides/dataplex/tpgtools_product.yaml

Adding AuthorizedOrgsDesc to AccessContextManager (GoogleCloudPlatform#7178) Allow project field in Firebase apps datasource (GoogleCloudPlatform#7300) * Allow project field in Firebase apps datasource * Add tf_test to the display name * update to capitalized dependencies Rename compute_(region)_per_instance_config test files to .erb files … (GoogleCloudPlatform#7409) * Rename compute_(region)_per_instance_config test files to .erb files since the resources have fields in beta. * Omit stateful_ip tests for GA Bootstrap network cleanup (GoogleCloudPlatform#7367) * Update bootstrapped networks for alloydb * Update bootstrapped networks for redis * Update bootstrapped networks for vertexai * Update comment for BootstrapSharedTestNetwork to be more clear Fix override directory concat (GoogleCloudPlatform#7413) Bootstrap required permissions for composer environment tests (GoogleCloudPlatform#7391) * Bootstrap the required permissions * Make BootstrapAllPSARoles actually work Also adds some helper functions for debugging what the bootstrap function does. It will now log the roles that were missing in the policy. * Add missing return, fix nits * Fix typo in service agent name * Account for newly exported test functions Add maintenance_interval field to Instance Template and Instance scheduling. (GoogleCloudPlatform#7365) * Move testing to handwritten * Move testing to handwritten * Fix lint * Fix typo * Add remove step and update documentation * Add remove step and update documentation * Fix comparing string to nil * Add field to handwritten defs * rebase on main & resolve conflicts * Fix doc formatting * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Change function names to valid * Fix type mismatch * Fix type mismatch * Fix function name Fix naming of resource policies in tests to be sweepable (GoogleCloudPlatform#7412) Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample (GoogleCloudPlatform#7415) Add support for Apigee Sharedflow (GoogleCloudPlatform#7202) * added sharedflows mmv1 with error * fix indentation issue for sharedflow * add semi auto generated resourceApigeeSharedFlow * remove sharedflow mmv1 and add sharedflow manual provider * adding files for debugging review, test have issue * adding files for debugging review, test have issue * update test, doc, provider for apigee * Update api.yaml remove empty new line * Update api.yaml * Rename resource_apigee_shared_flow_generated_test.go to resource_apigee_shared_flow_test.go * Update resource_apigee_shared_flow.go update import regex, change debug messages to log.Printf * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <[email protected]> * update PR to address comments * update test * fix sharedflow attribute update issue, add sharedflow deployment * Update apigee_shared_flow_deployment.html.markdown minor doc fix * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/apigee_shared_flow.html.markdown Co-authored-by: megan07 <[email protected]> * Update resource_apigee_shared_flow_test.go remove commented out (unused) line of code * Delete api.yaml remove api.yaml as it is not needed for handwritten resource. Current repo structure no longer uses aggregated api.yaml * Rename apigee_shared_flow.html.markdown to apigee_sharedflow.html.markdown * Rename apigee_shared_flow_deployment.html.markdown to apigee_sharedflow_deployment.html.markdown * Rename resource_apigee_shared_flow.go to resource_apigee_sharedflow.go * Rename resource_apigee_shared_flow_deployment_test.go to resource_apigee_sharedflow_deployment_test.go * Rename resource_apigee_shared_flow_test.go to resource_apigee_sharedflow_test.go * Rename resource_apigee_shared_flow_sweeper_test.go to resource_apigee_sharedflow_sweeper_test.go * Update resource_apigee_sharedflow.go remove comment lines * Update mmv1/third_party/terraform/resources/resource_apigee_sharedflow.go Co-authored-by: megan07 <[email protected]> * Update resource_apigee_sharedflow_deployment_test.go remove unused debugging log * update function name to capitalize * Update resource_apigee_sharedflow_deployment_test.go remove fmt.print * add flowhook * move flowhook doc * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <[email protected]> * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <[email protected]> * Update resource_apigee_flowhook_test.go remove fmt.print * update some resource attribute properties * Update apigee_flowhook.html.markdown updated `description` and `continue_on_error` as optional * update referenced function naming case --------- Co-authored-by: Ray Xu <[email protected]> Co-authored-by: megan07 <[email protected]> add tests (GoogleCloudPlatform#7357) Co-authored-by: Edward Sun <[email protected]> run gofmt + fix capitalization errors from previous PRs (GoogleCloudPlatform#7420) switch ci secrets to use secret manager (GoogleCloudPlatform#7408) Update field descriptions (GoogleCloudPlatform#7402) HA VPN over Cloud Interconnect has launched in GA We should still probably add a sample or two showing how to use it. Document PRODUCT_BASE_PATH override for DCL resource IAM (GoogleCloudPlatform#7418) yaqs/1723187608399380480 Add support for accelerators to google_datafusion_instance (GoogleCloudPlatform#6851) Added support to the field for Data Fusion, updated corresponding generated and handwritten tests, and added a custom diffsuppressfunc. Currently suggests a manual fix to a potential diff issue, will be able to update down line based on feedback from API team. Fix alloydb_cluster permadiff (GoogleCloudPlatform#7421) Fix dns_managed_zone tests using unverified domain (GoogleCloudPlatform#7422) Add SKIP_PROJECT_SWEEPER env variable for skipping the project sweeper (GoogleCloudPlatform#7432) Remove percent sign when parsing metadata name (GoogleCloudPlatform#7417) * Remove percent sign when parsing metadata name * Remove percent sign when parsing metadata name Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Add ignore read on reserved ip ranges (GoogleCloudPlatform#7429) Fix serviceusage links, clean up service resource stub (GoogleCloudPlatform#7435) Remove use of `make generate` from TPG/TPGB-specific step in CI (GoogleCloudPlatform#7379) Updating default accelerator.state field behavior in Data Fusion Instance (GoogleCloudPlatform#7434) Making suggested default behavior functionality updates in previous accelerators PR. Modify resource attribute 'input' to 'immutable' (GoogleCloudPlatform#7431) * Modify resource attribute 'input' to 'immutable' Remove noisy logging of project sweeper being skipped (GoogleCloudPlatform#7439) Fix PubSub-to-BigQuery push configuration example (GoogleCloudPlatform#7410) Rework + reflow provider reference, touch up index (GoogleCloudPlatform#7437) Fix eventarc tests to use dedicated bootstrapped keys (GoogleCloudPlatform#7440) Update docs for changing attribute `input` to `immutable` (GoogleCloudPlatform#7442) Feat name constraints (GoogleCloudPlatform#7400) Remove game_service_cluster_basic test (GoogleCloudPlatform#7443) send friendly_name (GoogleCloudPlatform#7433) * send friendly_name * fixed validator failures * update * fix validator errors --------- Co-authored-by: Edward Sun <[email protected]> Fix headline of google_iam_workload_identity_pool (GoogleCloudPlatform#7449) Move IAM bootstrap to its own file, improve error messages (GoogleCloudPlatform#7424) * Move IAM bootstrap to its own file, improve errors Also bootstrap roles/cloudbuild.builds.builder for cloudbuild service agent. * Re-add BootstrapConfig (accidentally deleted) * Fix wrong variable name * Bootstrap the role previously hardcoded for pubsub * Move error message back into bootstrap function This will dedup the code that calls this function. It now returns a boolean and sends the more useful error through t.Error. * Bootstrap the permissions for pubsub service agent * Bootstrap the role in the correct test * Fix formatting Changing name field on google_compute_disk for TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey to include randomly generated string (GoogleCloudPlatform#7392) * Changed name within google_compute_disk on line 3162 to inclue and randomly generated string * Cleaned up arguments being passed in to be more inline with other tests * Updated based on addtional PR comments * Fixed swapping of values within new context If not specified, a default Workstations service agent SA is returned (GoogleCloudPlatform#7428) * If not specified, a default service agent SA is returned * Revert "Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample" This reverts commit 097bdbe. * remove `rotation_period` update BigqueryDatapolicy to ga (GoogleCloudPlatform#6797) fix managed.dnsAuthorizations: (GoogleCloudPlatform#7445) Co-authored-by: Edward Sun <[email protected]> google_compute_security_policy: force send enforce_on_key so it can be unset on (GoogleCloudPlatform#7454) Make `hostname` and `matcher` fields immutable (GoogleCloudPlatform#7448) Add note on requiredness (GoogleCloudPlatform#7453) Update BootstrapProject to support use across multiple projects/environments (GoogleCloudPlatform#7369) * Update BootstrapProject to support use across multiple projects/environments * Fix typo * Fix arguments for getTestProjectFromEnv * Fix project naming strategy for BootstrapProject to produce valid names in all envs * Fix typo * Fix function name after rebase Update resource names in acceptance test to use `tf-test-` prefix (GoogleCloudPlatform#7450) fix datastream_stream dataset id import (GoogleCloudPlatform#7451) Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Removing api.yaml and replacing with per product configs Merge branch 'feature/iam_policy' of https://github.com/dbjnbnrj/magic-modules into feature/iam_policy

…c-modules into feature/iam_policy

shuyama1 · 2023-03-15T20:21:46Z

/gcbrun

modular-magician · 2023-03-15T20:38:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
TF Validator: Diff ( 11 files changed, 1109 insertions(+), 3 deletions(-))

modular-magician · 2023-03-15T21:25:19Z

Tests analytics

Total tests: 2509
Passed tests 2234
Skipped tests: 263
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccDataplexAssetIamPolicyGenerated|TestAccDataplexZoneIamBindingGenerated|TestAccDataplexZoneIamPolicyGenerated|TestAccDataplexAssetIamMemberGenerated|TestAccDataplexAssetIamBindingGenerated|TestAccDataplexZoneIamMemberGenerated|TestAccDataplexLakeIamPolicyGenerated|TestAccDataplexLakeIamMemberGenerated|TestAccDataplexLakeIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-15T22:11:58Z

Tests passed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer1[Debug log]
TestAccDataplexAssetIamPolicyGenerated[Debug log]
TestAccDataplexZoneIamBindingGenerated[Debug log]
TestAccDataplexZoneIamPolicyGenerated[Debug log]
TestAccDataplexAssetIamMemberGenerated[Debug log]
TestAccDataplexAssetIamBindingGenerated[Debug log]
TestAccDataplexZoneIamMemberGenerated[Debug log]
TestAccDataplexLakeIamPolicyGenerated[Debug log]
TestAccDataplexLakeIamMemberGenerated[Debug log]
TestAccDataplexLakeIamBindingGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

dbjnbnrj · 2023-03-15T22:31:41Z

Hi @shuyama1 looks like the two tests that failed are unrelated to my change
TestAccComposerEnvironment_withEncryptionConfigComposer2
TestAccDataSourceDnsManagedZone_basic

shuyama1 · 2023-03-16T15:52:12Z

/gcbrun

shuyama1 · 2023-03-16T15:53:06Z

Hi @shuyama1 looks like the two tests that failed are unrelated to my change TestAccComposerEnvironment_withEncryptionConfigComposer2 TestAccDataSourceDnsManagedZone_basic

Those failures are unrelated. Don't worry about them! Sorry for the noise.

modular-magician · 2023-03-16T16:08:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
TF Validator: Diff ( 11 files changed, 1109 insertions(+), 3 deletions(-))

modular-magician · 2023-03-16T16:56:31Z

Tests analytics

Total tests: 2510
Passed tests 2246
Skipped tests: 263
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-16T16:56:54Z

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

dbjnbnrj · 2023-03-16T19:36:50Z

Hi @shuyama1 looks like there was one failure, merged from main. Let me know if you can help! Thanks :)

shuyama1 · 2023-03-17T22:53:04Z

/gcbrun

dbjnbnrj · 2023-03-20T03:24:39Z

Hi @shuyama1 looks like workflow is waiting for approval from maintainer. Let me know if you can help

shuyama1 · 2023-03-20T19:32:29Z

/gcbrun

shuyama1

LGTM! Thank you! Will merge it after tests pass.

shuyama1 · 2023-03-20T21:45:31Z

/gcbrun

shuyama1 · 2023-03-20T22:04:17Z

tests failed due to:

google-beta/iam_dataplex_asset.go:48:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_asset.go:61:2: lake redeclared
	google-beta/iam_dataplex_asset.go:59:2: other declaration of lake
google-beta/iam_dataplex_asset.go:110:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_asset.go:161:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:43:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_zone.go:55:2: lake redeclared
	google-beta/iam_dataplex_zone.go:54:2: other declaration of lake
google-beta/iam_dataplex_zone.go:99:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:146:7: duplicate field name lake in struct literal
make: *** [vet] Error 2
GNUmakefile:26: recipe for target 'vet' failed
make: *** No rule to make target 'tools'.  Stop.
==> Checking that code complies with gofmt requirements...
go vet
# github.com/hashicorp/terraform-provider-google-beta/google-beta
google-beta/iam_dataplex_asset.go:48:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_asset.go:61:2: lake redeclared
	google-beta/iam_dataplex_asset.go:59:2: other declaration of lake
google-beta/iam_dataplex_asset.go:110:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_asset.go:161:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:43:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_zone.go:55:2: lake redeclared
	google-beta/iam_dataplex_zone.go:54:2: other declaration of lake
google-beta/iam_dataplex_zone.go:99:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:146:7: duplicate field name lake in struct literal
make: *** [vet] Error 2
GNUmakefile:26: recipe for target 'vet' failed
==> Checking that code complies with gofmt requirements...
go vet
# github.com/hashicorp/terraform-provider-google-beta/google-beta
google-beta/iam_dataplex_asset.go:48:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_asset.go:61:2: lake redeclared
	google-beta/iam_dataplex_asset.go:59:2: other declaration of lake
google-beta/iam_dataplex_asset.go:110:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_asset.go:161:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:43:2: duplicate key "lake" in map literal
google-beta/iam_dataplex_zone.go:55:2: lake redeclared
	google-beta/iam_dataplex_zone.go:54:2: other declaration of lake
google-beta/iam_dataplex_zone.go:99:7: duplicate field name lake in struct literal
google-beta/iam_dataplex_zone.go:146:7: duplicate field name lake in struct literal
GNUmakefile:26: recipe for target 'vet' failed
make: *** [vet] Error 2

Looking into the issue

…c-modules into feature/iam_policy

mmv1/products/dataplex/Asset.yaml

mmv1/products/dataplex/Zone.yaml

shuyama1 · 2023-03-20T22:11:15Z

Looks like you've already resolved it. Thanks for the quick fix.
/gcbrun

dbjnbnrj · 2023-03-20T22:25:51Z

Unsure why this is still failing, think the issue should be resolved now. Is the diff by any chance picking up the previous version?

shuyama1 · 2023-03-20T22:38:09Z

Looks like the provider tests passed which means the issue should be resolved, but the validator tests failed. Let me rerun the tests and also I'll grab someone who knows the validator better to take a look.
/gcbrun

shuyama1 · 2023-03-20T23:22:41Z

/gcbrun

shuyama1 · 2023-03-20T23:38:08Z

Looks like it got past the previous failure point.

Thanks for taking a look @melinath!

modular-magician · 2023-03-20T23:39:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 13 files changed, 2311 insertions(+), 14 deletions(-))
TF Validator: Diff ( 11 files changed, 1109 insertions(+), 3 deletions(-))

modular-magician · 2023-03-21T00:27:24Z

Tests analytics

Total tests: 2513
Passed tests 2247
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-21T00:31:03Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Thank you!

dbjnbnrj · 2023-03-21T02:53:39Z

Thank you so much for your help @shuyama1!! Thanks @melinath for helping with the failures :D

…atform#7436)

Adding IAM support for Dataplex Lake, Zone and Asset

b53aaca

dbjnbnrj requested a review from a team as a code owner March 9, 2023 23:11

dbjnbnrj requested review from shuyama1 and removed request for a team March 9, 2023 23:11

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

c62c860

shuyama1 reviewed Mar 15, 2023

View reviewed changes

tpgtools/overrides/dataplex/tpgtools_product.yaml Show resolved Hide resolved

dbjnbnrj and others added 3 commits March 15, 2023 12:40

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

10b7011

Merge branch 'feature/iam_policy' of https://github.com/dbjnbnrj/magi…

14d6305

…c-modules into feature/iam_policy

modular-magician requested a review from shuyama1 March 15, 2023 20:22

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

bd02106

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

f4cba49

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

58b4070

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

726b60a

shuyama1 approved these changes Mar 20, 2023

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy

36a9b52

modular-magician requested a review from shuyama1 March 20, 2023 21:46

dbjnbnrj added 2 commits March 20, 2023 22:04

Corrected Asset.yaml and Zone.yaml

8c145f6

Merge branch 'feature/iam_policy' of https://github.com/dbjnbnrj/magi…

db34b35

…c-modules into feature/iam_policy

shuyama1 requested changes Mar 20, 2023

View reviewed changes

mmv1/products/dataplex/Asset.yaml Outdated Show resolved Hide resolved

mmv1/products/dataplex/Zone.yaml Outdated Show resolved Hide resolved

dbjnbnrj requested a review from shuyama1 March 20, 2023 22:11

shuyama1 approved these changes Mar 21, 2023

View reviewed changes

shuyama1 merged commit fda318f into GoogleCloudPlatform:main Mar 21, 2023

dbjnbnrj deleted the feature/iam_policy branch March 21, 2023 02:52

dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023

Adding IAM resources for Dataplex Lake, Zone and Asset (GoogleCloudPl…

c2e9a6d

…atform#7436)

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Adding IAM resources for Dataplex Lake, Zone and Asset (GoogleCloudPl…

e5d98e7

…atform#7436)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding IAM resources for Dataplex Lake, Zone and Asset #7436

Adding IAM resources for Dataplex Lake, Zone and Asset #7436

dbjnbnrj commented Mar 9, 2023 •

edited by shuyama1

Loading

shuyama1 commented Mar 9, 2023

shuyama1 commented Mar 10, 2023

modular-magician commented Mar 10, 2023

modular-magician commented Mar 10, 2023

modular-magician commented Mar 10, 2023

dbjnbnrj commented Mar 11, 2023

shuyama1 left a comment •

edited

Loading

shuyama1 commented Mar 15, 2023

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

modular-magician commented Mar 15, 2023

dbjnbnrj commented Mar 15, 2023

shuyama1 commented Mar 16, 2023

shuyama1 commented Mar 16, 2023

modular-magician commented Mar 16, 2023

modular-magician commented Mar 16, 2023

modular-magician commented Mar 16, 2023

dbjnbnrj commented Mar 16, 2023

shuyama1 commented Mar 17, 2023

dbjnbnrj commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 left a comment

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

dbjnbnrj commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

modular-magician commented Mar 20, 2023

modular-magician commented Mar 21, 2023

modular-magician commented Mar 21, 2023

shuyama1 left a comment

dbjnbnrj commented Mar 21, 2023

Adding IAM resources for Dataplex Lake, Zone and Asset #7436

Adding IAM resources for Dataplex Lake, Zone and Asset #7436

Conversation

dbjnbnrj commented Mar 9, 2023 • edited by shuyama1 Loading

shuyama1 commented Mar 9, 2023

shuyama1 commented Mar 10, 2023

modular-magician commented Mar 10, 2023

Diff report

modular-magician commented Mar 10, 2023

Tests analytics

Action taken

modular-magician commented Mar 10, 2023

dbjnbnrj commented Mar 11, 2023

shuyama1 left a comment • edited Loading

Choose a reason for hiding this comment

shuyama1 commented Mar 15, 2023

modular-magician commented Mar 15, 2023

Diff report

modular-magician commented Mar 15, 2023

Tests analytics

Action taken

modular-magician commented Mar 15, 2023

dbjnbnrj commented Mar 15, 2023

shuyama1 commented Mar 16, 2023

shuyama1 commented Mar 16, 2023

modular-magician commented Mar 16, 2023

Diff report

modular-magician commented Mar 16, 2023

Tests analytics

Action taken

modular-magician commented Mar 16, 2023

dbjnbnrj commented Mar 16, 2023

shuyama1 commented Mar 17, 2023

dbjnbnrj commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

dbjnbnrj commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

shuyama1 commented Mar 20, 2023

modular-magician commented Mar 20, 2023

Diff report

modular-magician commented Mar 21, 2023

Tests analytics

Action taken

modular-magician commented Mar 21, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

dbjnbnrj commented Mar 21, 2023

dbjnbnrj commented Mar 9, 2023 •

edited by shuyama1

Loading

shuyama1 left a comment •

edited

Loading