compute_region_commitment

[c2thorn]

fixes hashicorp/terraform-provider-google#6734

this resource cannot be deleted, and lasts for a year+ which makes testing difficult in CI. I've tested locally and will request a manual removal of all CUDs created in my test project. Logs of successful test runs will be sent to the reviewer.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_commitment`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 965 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 965 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 238 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2521
Passed tests 2254
Skipped tests: 264
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 965 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 965 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 238 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2523
Passed tests 2254
Skipped tests: 264
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccDataSourceDnsManagedZone_basic|TestAccNetworkServicesGateway_update

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 919 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 919 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 238 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 238 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_commitment (0 total tests)
Untested fields: region, plan, auto_renew, name, category, license_resource.license, license_resource.amount, license_resource.cores_per_license, type, description, resources.amount, resources.type, resources.accelerator_type

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2609
Passed tests 2328
Skipped tests: 277
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test