Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax boolean conversions to accept varying cases #7637

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Apr 5, 2023

Relax boolean conversions to DCL accept varying cases.

Release Note Template for Downstream PRs (will be copied)

orgpolicy: accepted variable cases for booleans such as true, True, and TRUE in `google_org_policy_policy`

@sethvargo sethvargo requested a review from a team as a code owner April 5, 2023 14:33
@sethvargo sethvargo requested review from c2thorn and removed request for a team April 5, 2023 14:33
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 92 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 92 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2552
Passed tests 2272
Skipped tests: 275
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeForwardingRule_update|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]

All tests passed
View the build log or the debug log for each test

@c2thorn c2thorn merged commit 4c1fd77 into GoogleCloudPlatform:main Apr 6, 2023
@sethvargo sethvargo deleted the sethvargo/bool branch April 6, 2023 17:59
jingcongw pushed a commit to jingcongw/magic-modules-test that referenced this pull request Apr 7, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 12, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants