Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session affinity v2 #7648

Merged

Conversation

kminsu-google
Copy link
Member

@kminsu-google kminsu-google commented Apr 5, 2023

Cloud Run V2 API just added a support for session affinity by adding a boolean field to control it.
Adding the same field to be supported in Terraform for Cloud Run V2
Part of hashicorp/terraform-provider-google#13748

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added support for `session_affinity` to `google_cloud_run_v2_service`

@kminsu-google kminsu-google requested a review from a team as a code owner April 5, 2023 23:02
@kminsu-google kminsu-google requested review from c2thorn and removed request for a team April 5, 2023 23:02
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 5, 2023
@c2thorn
Copy link
Member

c2thorn commented Apr 6, 2023

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 6, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2559
Passed tests 2278
Skipped tests: 275
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@kminsu-google
Copy link
Member Author

kminsu-google commented Apr 6, 2023

Note on failing tests:
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate -> I totally thought our rollout (for Cloud Run) for this week has completed, just checked and us-central1 only has part of the cells with new binary (that has this field change). Sorry about this. I believe the test should pass if re-run after the rollout is done.

TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey -> Not quite sure of this test. There's no point any error occured, and it says "resource_container_cluster_test.go:3065: Stopping the test because a role was added to the policy." and it's marked failure. I can check with my teammates if they are aware of this issue, but also please let me know if you have an idea why this test fails in this manner.

Once the rollout completes, I will try to run the command above /gcbrun to re-evaluate this PR.

@c2thorn
Copy link
Member

c2thorn commented Apr 6, 2023

Note on failing tests: TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate -> I totally thought our rollout (for Cloud Run) for this week has completed, just checked and us-central1 only has part of the cells with new binary (that has this field change). Sorry about this. I believe the test should pass if re-run after the rollout is done.

No problem, please ping me here or internally whenever you want me to re-run.

TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey -> Not quite sure of this test. There's no point any error occured, and it says "resource_container_cluster_test.go:3065: Stopping the test because a role was added to the policy." and it's marked failure. I can check with my teammates if they are aware of this issue, but also please let me know if you have an idea why this test fails in this manner.

I'm very certain this test in failing unrelated to your change. Don't worry about it.

Once the rollout completes, I will try to run the command above /gcbrun to re-evaluate this PR.

I don't believe you'll have permission, since it didn't autorun when you pushed your commit.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 6, 2023
@kminsu-google
Copy link
Member Author

Happy Monday @c2thorn, I just double checked that the new binary has been rolled out to all us-central1(also to all prod regions). Could we run the check one more time?

@c2thorn
Copy link
Member

c2thorn commented Apr 10, 2023

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 10, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2562
Passed tests 2282
Skipped tests: 275
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@kminsu-google
Copy link
Member Author

@c2thorn Hi Cameron, I believe the change needed to be made actually got rolled out to prod last week.
Could we run the check once again?

Thank you so much!

@rileykarson
Copy link
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2625
Passed tests 2330
Skipped tests: 277
Affected tests: 18

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_settings_upgrade

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_activationPolicy[Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled[Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccSqlDatabaseInstance_settings_basic[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection[Debug log]
TestAccSqlDatabaseInstance_settings_secondary[Debug log]
TestAccSqlDatabaseInstance_authNets[Debug log]
TestAccSqlDatabaseInstance_settingsDowngrade[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled[Debug log]
TestAccSqlDatabaseInstance_settings_upgrade[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@kminsu-google
Copy link
Member Author

Might be a visibility label issue. Retrying after updating the LABELs for the test project.

@kminsu-google
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))
TF Conversion: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2630
Passed tests 2347
Skipped tests: 277
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@kminsu-google
Copy link
Member Author

Failed test does not seem to be related to the change made in this PR. Waiting for reviewer to confirm.

@c2thorn c2thorn merged commit 06880fc into GoogleCloudPlatform:main Apr 20, 2023
ravisiddhu pushed a commit to ravisiddhu/magic-modules that referenced this pull request Apr 25, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants