-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding startup_cpu_boost field for cloud run v2 service. #7732
Adding startup_cpu_boost field for cloud run v2 service. #7732
Conversation
@megan07 Hi, could you run the integration test for this PR? Thanks you! |
/gcbrun |
Tests analyticsTotal tests: Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccAlloydbBackup_missingLocation|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example |
The provider crashed while running the VCR tests in RECORDING mode |
Test run timed out for some reason, re-running. |
/gcbrun |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: All tests passed |
@megan07 it seems like the integration test succeeded. Please take a look when you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate
passed in the crashed VCR run, which seems to be why it didn't appear in the second run
Cloud Run V2 API just removed a visibility label from boolean field "startup_cpu_boost"
Adding the same field to be supported in Terraform for Cloud Run V2
Fixes hashicorp/terraform-provider-google#13908
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)