Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding startup_cpu_boost field for cloud run v2 service. #7732

Merged

Conversation

kminsu-google
Copy link
Member

@kminsu-google kminsu-google commented Apr 14, 2023

Cloud Run V2 API just removed a visibility label from boolean field "startup_cpu_boost"
Adding the same field to be supported in Terraform for Cloud Run V2
Fixes hashicorp/terraform-provider-google#13908

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added field `startupCpuBoost` to resource `service`

@kminsu-google
Copy link
Member Author

@megan07 Hi, could you run the integration test for this PR?
It seems to be blocked by something and staying queued.

Thanks you!

@kminsu-google
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2625
Passed tests 2331
Skipped tests: 277
Affected tests: 17

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccAlloydbBackup_missingLocation|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

@kminsu-google
Copy link
Member Author

Test run timed out for some reason, re-running.

@kminsu-google
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 28 insertions(+))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2630
Passed tests 2348
Skipped tests: 277
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

@kminsu-google
Copy link
Member Author

@megan07 it seems like the integration test succeeded. Please take a look when you have a chance.

@c2thorn c2thorn requested review from c2thorn and removed request for megan07 April 20, 2023 17:03
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate passed in the crashed VCR run, which seems to be why it didn't appear in the second run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startup-cpu-boost and cpu-throttling options for google_cloud_run_v2_service
3 participants