-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for Endpoint policy #7751
Add configuration for Endpoint policy #7751
Conversation
This reverts commit 367449a.
Co-authored-by: Sam Levenick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could I get you to merge main
in again? There was a file rename that's tripped our CI up a bit, and I'm not entirely certain what that will affect w/ generation.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 189 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_upgrade|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
The provider crashed while running the VCR tests in RECORDING mode |
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 189 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic |
Tests passed during RECORDING mode: All tests passed |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 217 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more questions about tests, sorry! Let's cover a few more fields' update. Additionally, is there something blocking us from testing the remaining fields (authorization_policy, client_tls_policy, server_tls_policy) or could we work those in to the tests as well?
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_network_services_endpoint_policy_test.go.erb
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample|TestAccNetworkServicesEndpointPolicy_update|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
…point_policy_test.go.erb Co-authored-by: Riley Karson <[email protected]>
…point_policy_test.go.erb Co-authored-by: Riley Karson <[email protected]>
…point_policy_test.go.erb Co-authored-by: Riley Karson <[email protected]>
…point_policy_test.go.erb Co-authored-by: Riley Karson <[email protected]>
…point_policy_test.go.erb Co-authored-by: Riley Karson <[email protected]>
Thanks for the suggestions, committed those. Yes the remaining test fields cannot be tested yet as we do not have TF modules for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running tests, will LGTM & merge assuming they're all good.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 217 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkServicesEndpointPolicy_update|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccComputeForwardingRule_update|TestAccAlloydbBackup_missingLocation |
Tests passed during RECORDING mode: All tests passed |
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Madhura Phadnis <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Madhura Phadnis <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Madhura Phadnis <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Madhura Phadnis <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Madhura Phadnis <[email protected]>
Add configuration for traffic director endpointPolicy resource
part of hashicorp/terraform-provider-google#14038
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)