Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for Endpoint policy #7751

Merged
merged 21 commits into from
Apr 24, 2023

Conversation

maphad
Copy link
Contributor

@maphad maphad commented Apr 17, 2023

Add configuration for traffic director endpointPolicy resource

part of hashicorp/terraform-provider-google#14038

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_networkservices_endpoint_policy`

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could I get you to merge main in again? There was a file rename that's tripped our CI up a bit, and I'm not entirely certain what that will affect w/ generation.

mmv1/products/networkservices/EndpointPolicy.yaml Outdated Show resolved Hide resolved
mmv1/products/networkservices/EndpointPolicy.yaml Outdated Show resolved Hide resolved
mmv1/products/networkservices/EndpointPolicy.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 189 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1296 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 123 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_endpoint_policy (3 total tests)
Untested fields: server_tls_policy, authorization_policy, client_tls_policy

Please add acceptance tests which include these fields.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2627
Passed tests 2332
Skipped tests: 277
Affected tests: 18

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_basic|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_upgrade|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 189 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1296 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 123 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_endpoint_policy (3 total tests)
Untested fields: authorization_policy, client_tls_policy, server_tls_policy

Please add acceptance tests which include these fields.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2644
Passed tests 2357
Skipped tests: 277
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesEndpointPolicy_update[Debug log]
TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 217 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1372 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_endpoint_policy (4 total tests)
Untested fields: server_tls_policy, authorization_policy, client_tls_policy

Please add acceptance tests which include these fields.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more questions about tests, sorry! Let's cover a few more fields' update. Additionally, is there something blocking us from testing the remaining fields (authorization_policy, client_tls_policy, server_tls_policy) or could we work those in to the tests as well?

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2650
Passed tests 2365
Skipped tests: 277
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample|TestAccNetworkServicesEndpointPolicy_update|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample[Debug log]
TestAccNetworkServicesEndpointPolicy_update[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

maphad and others added 3 commits April 24, 2023 11:10
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2023
@maphad
Copy link
Contributor Author

maphad commented Apr 24, 2023

Few more questions about tests, sorry! Let's cover a few more fields' update. Additionally, is there something blocking us from testing the remaining fields (authorization_policy, client_tls_policy, server_tls_policy) or could we work those in to the tests as well?

Thanks for the suggestions, committed those. Yes the remaining test fields cannot be tested yet as we do not have TF modules for them.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running tests, will LGTM & merge assuming they're all good.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 217 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1371 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 242 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2673
Passed tests 2384
Skipped tests: 280
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesEndpointPolicy_update|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccComputeForwardingRule_update|TestAccAlloydbBackup_missingLocation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesEndpointPolicy_update[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]

All tests passed
View the build log or the debug log for each test

@rileykarson rileykarson merged commit 14b8721 into GoogleCloudPlatform:main Apr 24, 2023
ravisiddhu pushed a commit to ravisiddhu/magic-modules that referenced this pull request Apr 25, 2023
maphad added a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad added a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad added a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants