Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for Authorization policy #7792

Merged
merged 24 commits into from
May 2, 2023

Conversation

maphad
Copy link
Contributor

@maphad maphad commented Apr 20, 2023

Add configuration for traffic director authorizationPolicy resource

part of hashicorp/terraform-provider-google#14040

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_authorization_policy`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 20, 2023
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could join the GoogleCloudOrganization so our CI can detect you?
Join GoogleCloudPlatform org through go/github/orgs

I notice this is in draft state. Let me know if there is anything I can help with in the meantime while you work on this

@maphad maphad marked this pull request as ready for review April 26, 2023 16:57
@maphad
Copy link
Contributor Author

maphad commented Apr 26, 2023

Could join the GoogleCloudOrganization so our CI can detect you? Join GoogleCloudPlatform org through go/github/orgs

I notice this is in draft state. Let me know if there is anything I can help with in the meantime while you work on this

Thanks, I am already part of the GoogleCloudOrg. Marked the PR as ready for review now.

@ScottSuarez
Copy link
Contributor

Strange !! Our automation should be picking you your bit and running! Not sure why. I'll go ahead and manually approve

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 26, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 226 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1363 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2681
Passed tests 2389
Skipped tests: 278
Affected tests: 14

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkSecurityAuthorizationPolicy_update|TestAccNetworkSecurityAuthorizationPolicy_networkSecurityAuthorizationPolicyBasicExample|TestAccNetworkSecurityAuthorizationPolicy_networkSecurityAuthorizationPolicyDestinationsExample|TestAccFirebaserulesRelease_BasicRelease|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkSecurityAuthorizationPolicy_update[Debug log]
TestAccNetworkSecurityAuthorizationPolicy_networkSecurityAuthorizationPolicyBasicExample[Debug log]
TestAccNetworkSecurityAuthorizationPolicy_networkSecurityAuthorizationPolicyDestinationsExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBigQueryDataTable_bigtable[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Error message] [Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
ls: cannot access 'website/docs/**/*.md': No such file or directory
make: *** [GNUmakefile:26: vet] Error 2
google-beta/resource_container_cluster.go:5070:38: undefined: container.K8sBetaAPIConfig
google-beta/resource_container_cluster.go:4511:20: undefined: container.K8sBetaAPIConfig
google-beta/resource_container_cluster.go:4505:64: undefined: container.K8sBetaAPIConfig
google-beta/resource_container_cluster.go:3292:6: unknown field 'DesiredK8sBetaApis' in struct literal of type container.ClusterUpdate
google-beta/resource_container_cluster.go:2494:69: cluster.EnableK8sBetaApis undefined (type *container.Cluster has no field or method EnableK8sBetaApis)
google-beta/resource_container_cluster.go:2117:11: cluster.EnableK8sBetaApis undefined (type *container.Cluster has no field or method EnableK8sBetaApis)
# github.com/hashicorp/terraform-provider-google-beta/google-beta
go vet

compilation error... suspect you need to upgrade a package

@maphad maphad force-pushed the authorization-policy branch from a383157 to 31fd776 Compare April 27, 2023 16:42
@maphad maphad changed the base branch from 0.12-fixes to main April 27, 2023 16:56
@maphad maphad force-pushed the authorization-policy branch 3 times, most recently from 5c7c088 to 31fd776 Compare April 27, 2023 17:05
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 27, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 226 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1363 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2692
Passed tests 2406
Skipped tests: 279
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@maphad maphad force-pushed the authorization-policy branch from 31fd776 to 15cfdc2 Compare April 27, 2023 22:43
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 27, 2023
Madhura Phadnis added 2 commits April 27, 2023 22:44
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 1, 2023
@ScottSuarez
Copy link
Contributor

Could join the GoogleCloudOrganization so our CI can detect you? Join GoogleCloudPlatform org through go/github/orgs
I notice this is in draft state. Let me know if there is anything I can help with in the meantime while you work on this

Thanks, I am already part of the GoogleCloudOrg. Marked the PR as ready for review now.

Does not look like you are apart of the organization.. https://github.com/orgs/GoogleCloudPlatform/people?query=maphad

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 226 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2703
Passed tests 2418
Skipped tests: 279
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants