Add google_gkeonprem_bare_metal_cluster resource

[naitianliu-google]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gkeonprem_bare_metal_cluster`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1205 insertions(+))
Terraform Beta: Diff ( 6 files changed, 6710 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1205 insertions(+))
Terraform Beta: Diff ( 6 files changed, 6704 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2679
Passed tests 2388
Skipped tests: 280
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic|TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBgplbExample|TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterManuallbExample|TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBasicExample|TestAccBigQueryJob_bigqueryJobLoadGeojsonExample|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic[Debug log]
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBgplbExample[Debug log]
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterManuallbExample[Debug log]
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBasicExample[Debug log]
TestAccBigQueryJob_bigqueryJobLoadGeojsonExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1205 insertions(+))
Terraform Beta: Diff ( 6 files changed, 6866 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2706
Passed tests 2416
Skipped tests: 279
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeForwardingRule_update|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

[ScottSuarez]

Is there external facing documentation for this API. Its tough to validate this resource model when there is no external documentation

[naitianliu-google]

Is there external facing documentation for this API. Its tough to validate this resource model when there is no external documentation

Yes, here is the API docs https://cloud.devsite.corp.google.com/anthos/clusters/docs/on-prem-api/reference/rest (devsite is corp-only)

[modular-magician]

Tests passed during RECORDING mode:
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

All tests passed
View the build log or the debug log for each test

[ScottSuarez]

cloud.devsite.corp.google.com/anthos/clusters/docs/on-prem-api/reference/rest

Any reason for internal only docs? Why not externally available ?

[ScottSuarez]

Asking for tests on fields that don't seem to have associated examples. If a test can't be supplied thats ok. Just provide a comment with a reason. As long as they are consciously excluded

[naitianliu-google]

Thanks for taking time reviewing this PR. Added accordingly by increasing test coverage and fixing the Resource config file based on test results. Please let me know if anything else needs to be updated. Thanks! @ScottSuarez

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1190 insertions(+))
Terraform Beta: Diff ( 6 files changed, 6655 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2706
Passed tests 2418
Skipped tests: 279
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBgplbExample|TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBgplbExample[Debug log]
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

[naitianliu-google]

cloud.devsite.corp.google.com/anthos/clusters/docs/on-prem-api/reference/rest

Any reason for internal only docs? Why not externally available ?

Here is the public one which was just released. https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest

[ScottSuarez]

Some fields don't appear to be documented externally or are represented differently.. Could you confirm?

[naitianliu-google]

Some fields don't appear to be documented externally or are represented differently.. Could you confirm?

The external document is to up-to-date. The latest version is not released yet. Please reference the internal one for the latest changes. (Apologize for the incorrect reference. ) https://cloud.devsite.corp.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.bareMetalClusters#BareMetalNetworkConfig

[naitianliu-google]

@ScottSuarez @rileykarson Please help give a pass on this PR when you get a chance. Thanks!