Migrating GKEHub Feature from DCL to MMv1

[sahsagar-google]

Fixes hashicorp/terraform-provider-google#14728

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gke_hub_feature` (ga only)

`google_gke_hub_feature_iam_*`

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_gke_hub_feature was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 931 insertions(+), 149 deletions(-))
Terraform Beta: Diff ( 13 files changed, 940 insertions(+), 703 deletions(-))
TF Conversion: Diff ( 5 files changed, 146 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub2_feature (0 total tests)
Untested fields: spec.multiclusteringress.config_membership, name, labels, location

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2747
Passed tests 2456
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[shuyama1]

Hi @sahsagar-google! Are you able to build providers and run tests locally? or are you waiting on my approval to run presubmit tests in the CI, which will run the whole test suite and take about 1.5 hour to get the results. So running tests locally is strongly encouraged for fast test result.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[shuyama1]

@sahsagar-google Please check the internal contribution guide to get tests automatically triggered for your PR. Feel free to ping me internally and I can link your the page if needed. Thanks!

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[sahsagar-google]

< pr description>

gkehub: Promoted resource 'feature' from Beta to GA provider

gkehub: Migrated resource 'feature' from DCL to MMv1

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 2024 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 16 files changed, 2127 insertions(+), 786 deletions(-))
TF Conversion: Diff ( 8 files changed, 511 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_iam_binding (2 total tests)
Untested fields: condition.expression, condition.title, condition.description

Please add acceptance tests which include these fields.
Resource: google_gke_hub_feature_iam_member (1 total tests)
Untested fields: condition.title, condition.description, condition.expression

Please add acceptance tests which include these fields.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 2024 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 16 files changed, 2127 insertions(+), 786 deletions(-))
TF Conversion: Diff ( 8 files changed, 511 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_iam_binding (2 total tests)
Untested fields: condition.expression, condition.title, condition.description

Please add acceptance tests which include these fields.
Resource: google_gke_hub_feature_iam_member (1 total tests)
Untested fields: condition.title, condition.description, condition.expression

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2791
Passed tests 2490
Skipped tests: 297
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2FeatureIamMemberGenerated|TestAccGKEHub2FeatureIamBindingGenerated|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 2791
Passed tests 2491
Skipped tests: 297
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2FeatureIamPolicyGenerated|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccGKEHub2FeatureIamMemberGenerated[Debug log]
TestAccGKEHub2FeatureIamBindingGenerated[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Tests passed during RECORDING mode:
TestAccGKEHub2FeatureIamPolicyGenerated[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

Running skipped tests on TC:
beta: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/410219
GA: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/410223

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 2030 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 16 files changed, 2133 insertions(+), 786 deletions(-))
TF Conversion: Diff ( 8 files changed, 511 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_iam_binding (2 total tests)
Untested fields: condition.title, condition.description, condition.expression

Please add acceptance tests which include these fields.
Resource: google_gke_hub_feature_iam_member (1 total tests)
Untested fields: condition.title, condition.description, condition.expression

Please add acceptance tests which include these fields.

[modular-magician]

Tests analytics

Total tests: 2791
Passed tests 2489
Skipped tests: 300
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

Tests failed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

LGTM. The failing tests are not related. Thank you!

[JeffLuoo]

May I ask how can I check the documentation of GKEHub Feature after the migration with this PR?

[shuyama1]

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/gke_hub_feature is the web documentation page of google_gkehub_feature. After this PR is released, the page should look like https://github.com/hashicorp/terraform-provider-google/blob/main/website/docs/r/gke_hub_feature.html.markdown.

[JeffLuoo]

Thank you Shuya!