Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using different values for the field purpose. #8070

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

mdetemad
Copy link
Contributor

@mdetemad mdetemad commented Jun 1, 2023

Updated the field purpose to be of type String that enables using different values for the field .

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

kms: removed validation for `purpose` in `google_kms_crypto_key` to allow newly added values for the field

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician modular-magician requested a review from shuyama1 June 1, 2023 21:37
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field purpose default value changed from ENCRYPT_DECRYPT to on google_kms_crypto_key - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2760
Passed tests 2443
Skipped tests: 283
Affected tests: 34

Action taken

Found 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccSqlUser_postgresIAM|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_encryptionKey|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccDataFusionInstance_dataFusionInstanceCmekExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccAlloydbBackup_usingCMEK|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbCluster_usingCMEK|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccKmsCryptoKeyVersion_patch|TestAccKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccKmsCryptoKeyIamMember|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamBinding|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlUser_postgresAbandon[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccSqlUser_postgresIAM[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]
TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion[Error message] [Debug log]
TestAccSqlDatabaseInstance_encryptionKey[Error message] [Debug log]
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Error message] [Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample[Error message] [Debug log]
TestAccComputeMachineImage_computeMachineImageKmsExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccBigQueryJob_bigqueryJobCopyExample[Error message] [Debug log]
TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample[Error message] [Debug log]
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Error message] [Debug log]
TestAccAlloydbCluster_usingCMEK[Error message] [Debug log]
TestAccKmsCryptoKeyVersion_patch[Error message] [Debug log]
TestAccKmsCryptoKeyVersion_basic[Error message] [Debug log]
TestAccKmsCryptoKey_importOnly[Error message] [Debug log]
TestAccKmsCryptoKey_destroyDuration[Error message] [Debug log]
TestAccKmsCryptoKeyIamBinding_withCondition[Error message] [Debug log]
TestAccKmsCryptoKey_basic[Error message] [Debug log]
TestAccKmsCryptoKeyIamPolicy_withCondition[Error message] [Debug log]
TestAccKmsCryptoKeyIamMember[Error message] [Debug log]
TestAccKmsCryptoKeyIamPolicy[Error message] [Debug log]
TestAccKmsCryptoKeyVersion_skipInitialVersion[Error message] [Debug log]
TestAccKmsCryptoKeyIamMember_withCondition[Error message] [Debug log]
TestAccKmsCryptoKeyIamBinding[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@shuyama1
Copy link
Member

shuyama1 commented Jun 2, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the last build was failed. Rerun seems work and let's wait for the test result. Overall looks good. Only one small doc change suggestion.

mmv1/products/kms/CryptoKey.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2762
Passed tests 2472
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

@modular-magician modular-magician requested a review from shuyama1 June 2, 2023 17:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2766
Passed tests 2476
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1 shuyama1 merged commit 902c76d into GoogleCloudPlatform:main Jun 2, 2023
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jun 7, 2023
…form#8070)

* Enable using different values for the field purpose.

* Enable using different values for the field purpose.

* Update the default values for the field purpose.

* Update mmv1/products/kms/CryptoKey.yaml

Co-authored-by: Shuya Ma <[email protected]>

---------

Co-authored-by: Shuya Ma <[email protected]>
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…form#8070)

* Enable using different values for the field purpose.

* Enable using different values for the field purpose.

* Update the default values for the field purpose.

* Update mmv1/products/kms/CryptoKey.yaml

Co-authored-by: Shuya Ma <[email protected]>

---------

Co-authored-by: Shuya Ma <[email protected]>
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…form#8070)

* Enable using different values for the field purpose.

* Enable using different values for the field purpose.

* Update the default values for the field purpose.

* Update mmv1/products/kms/CryptoKey.yaml

Co-authored-by: Shuya Ma <[email protected]>

---------

Co-authored-by: Shuya Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants