-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for advanced_datapath_observability_config
to google_container_cluster
#8372
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
63cd5fe
to
ed0ca1d
Compare
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_container_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 112 insertions(+), 32 deletions(-)) |
Tests analyticsTotal tests:
|
From the failing build:
|
96933fb
to
712c5b9
Compare
advanced_datapath
metrics to google_container_cluster
advanced_datapath_observability_config
to google_container_cluster
@rileykarson should be good to test/review. Thanks! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 172 insertions(+), 37 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig|TestAccContainerCluster_withMonitoringConfig|TestAccComputeInstance_minCpuPlatform|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
Rerun these tests in REPLAYING mode to catch issues
|
Rebased on main |
d6b942f
to
63eca84
Compare
…oogle_container_cluster Signed-off-by: Aditya Sharma <[email protected]>
Adds support for https://cloud.google.com/kubernetes-engine/docs/how-to/configure-dpv2-observability#configure-gke-dataplane-v2-metrics
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)