-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting sendPreviousResourceOnDelete
for FHIR store notification configs.
#8507
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
… notification configs.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 11 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareFhirStore_healthcareFhirStoreNotificationConfigsExample|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need an update test, otherwise looks good
@@ -309,3 +309,11 @@ properties: | |||
full FHIR resource. When a resource change is too large or during heavy traffic, only the resource name will be | |||
sent. Clients should always check the "payloadType" label from a Pub/Sub message to determine whether | |||
it needs to fetch the full resource as a separate operation. | |||
- !ruby/object:Api::Type::Boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that specifies this in the update test for this resource? Just to check that the functionality works during update, especially going from specifying this field to not specifying it.
It can be added to the existing update test here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/tests/resource_healthcare_fhir_store_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I added it correctly but let me know if there is something else you had in mind!
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 11 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareFhirStore_basic|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
… notification configs. (GoogleCloudPlatform#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete
… notification configs. (GoogleCloudPlatform#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete
… notification configs. (GoogleCloudPlatform#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete
… notification configs. (GoogleCloudPlatform#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete
Fixes hashicorp/terraform-provider-google#15349.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)