Add the latest changes in Datascan API #8541

evasharma · 2023-08-03T16:49:45Z

Updating Datascan terraform support with the latest changes and additions in Datascan API.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[X ] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataplex: added fields `data_profile_spec.post_scan_actions`, `data_profile_spec.include_fields` and `data_profile_spec.exclude_fields`

modular-magician · 2023-08-03T16:50:14Z

Hello! I am a robot. It looks like you are a community contributor. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

ScottSuarez · 2023-08-03T17:16:13Z

mmv1/products/dataplex/Datascan.yaml

+              Expected input is a list of fully qualified names of fields as in the schema.
+              Only top-level field names for nested fields are supported.
+              For instance, if 'x' is of nested field type, listing 'x' is supported but 'x.y.z' is not supported. Here 'y' and 'y.z' are nested fields of 'x'.
+            item_type: !ruby/object:Api::Type::String


Suggested change

item_type: !ruby/object:Api::Type::String

item_type: Api::Type::String

Thanks Fixed!

ScottSuarez · 2023-08-03T17:16:26Z

mmv1/products/dataplex/Datascan.yaml

+              Expected input is a list of fully qualified names of fields as in the schema.
+              Only top-level field names for nested fields are supported.
+              For instance, if 'x' is of nested field type, listing 'x' is supported but 'x.y.z' is not supported. Here 'y' and 'y.z' are nested fields of 'x'.
+            item_type: !ruby/object:Api::Type::String


Suggested change

item_type: !ruby/object:Api::Type::String

item_type: item_type: Api::Type::String

Thanks Fixed!

ScottSuarez · 2023-08-03T17:19:52Z

mmv1/products/dataplex/Datascan.yaml

+      - !ruby/object:Api::Type::NestedObject
+        name: 'postScanActionsResult'
+        decription: |
+           The result of post scan actions.
+        properties:
+          - !ruby/object:Api::Type::NestedObject
+            name: 'bigQueryExportResult'
+            description: |
+              The result of BigQuery export post scan action.
+            properties:
+              - !ruby/object:Api::Type::Enum
+                name: 'state'
+                decription: |
+                  Execution state for the BigQuery exporting.
+                values:
+                  - STATE_UNSPECIFIED
+                  - SUCCEEDED
+                  - FAILED
+                  - SKIPPED
+              - !ruby/object:Api::Type::String
+                name: 'message'
+                description: |
+                  Additional information about the BigQuery exporting.


This whole block seems like it should be an output field.

Note that we are looking to remove the DataProfileResult and DataQualityResult in this PR: #8583 (comment)

Based on how that discussion goes, we should look at only adding the export and rule name fields in the spec, and not in the result.

@evasharma

Thanks removed the fields added in this PR, the rest of the Result field to be removed in @saurabh-net PR.

ScottSuarez · 2023-08-03T17:20:30Z

mmv1/products/dataplex/Datascan.yaml

+                - !ruby/object:Api::Type::String
+                  name: 'name'
+                  description: |
+                    A mutable name for the rule.
+                    The name must contain only letters (a-z, A-Z), numbers (0-9), or hyphens (-).
+                    The maximum length is 63 characters.
+                    Must start with a letter.
+                    Must end with a number or a letter.
+                - !ruby/object:Api::Type::String
+                  name: 'description'
+                  description: |
+                    Description of the rule.
+                    The maximum length is 1,024 characters.


likely output fields

Thanks removed the fields added in this PR, the rest of the Result field to be removed in @saurabh-net PR.

ScottSuarez · 2023-08-03T17:21:11Z

mmv1/products/dataplex/Datascan.yaml

+      - !ruby/object:Api::Type::NestedObject
+        name: 'postScanActionsResult'
+        decription: |
+           The result of post scan actions.
+        properties:
+          - !ruby/object:Api::Type::NestedObject
+            name: 'bigQueryExportResult'
+            description: |
+              The result of BigQuery export post scan action.
+            properties:
+              - !ruby/object:Api::Type::Enum
+                name: 'state'
+                decription: |
+                  Execution state for the BigQuery exporting.
+                values:
+                  - STATE_UNSPECIFIED
+                  - SUCCEEDED
+                  - FAILED
+                  - SKIPPED
+              - !ruby/object:Api::Type::String
+                name: 'message'
+                description: |
+                  Additional information about the BigQuery exporting.


output only

Thanks removed the fields added in this PR, the rest of the Result field to be removed in @saurabh-net PR.

ScottSuarez · 2023-08-03T17:23:50Z

mmv1/products/dataplex/Datascan.yaml

+              - !ruby/object:Api::Type::String
+                name: 'resultsTable'
+                description: |
+                  The BigQuery table to export DataProfileScan results to.
+                  Format:projects/{project}/datasets/{dataset}/tables/{table}


Is it possible to test this field. It's okay if not just want to ensure we are conscious in it's exclusion.

It is required field and has been tested.

modular-magician · 2023-08-10T15:04:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    post_scan_actions {
      big_query_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      big_query_export {
        results_table = # value needed
      }
    }
    rules {
      description = # value needed
      name        = # value needed
    }
  }
}

modular-magician · 2023-08-10T16:43:22Z

Tests analytics

Total tests: 2939
Passed tests 2630
Skipped tests: 302
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataplexDatascanIamPolicyGenerated|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated

Get to know how VCR tests work

modular-magician · 2023-08-10T16:47:12Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-10T17:25:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 565 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    post_scan_actions {
      big_query_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      big_query_export {
        results_table = # value needed
      }
    }
  }
}

modular-magician · 2023-08-10T19:05:29Z

Tests analytics

Total tests: 2939
Passed tests 2631
Skipped tests: 302
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-10T19:08:54Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-10T20:05:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

modular-magician · 2023-08-10T21:26:02Z

Tests analytics

Total tests: 2939
Passed tests 2632
Skipped tests: 302
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-10T21:28:14Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…at in the examples in yaml

modular-magician · 2023-08-10T22:43:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 560 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

modular-magician · 2023-08-10T23:40:07Z

Tests analytics

Total tests: 2939
Passed tests 2632
Skipped tests: 302
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascanIamPolicyGenerated|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample

Get to know how VCR tests work

modular-magician · 2023-08-10T23:43:24Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-11T00:09:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 522 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 4 files changed, 522 insertions(+), 22 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
}

modular-magician · 2023-08-11T01:06:47Z

Tests analytics

Total tests: 2939
Passed tests 2636
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicQualityExample

Get to know how VCR tests work

modular-magician · 2023-08-11T01:08:35Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

mmv1/products/dataplex/Datascan.yaml

…path

modular-magician · 2023-08-14T16:36:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    exclude_fields {
      field_names = # value needed
    }
    include_fields {
      field_names = # value needed
    }
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
    rules {
      description = # value needed
      name        = # value needed
    }
  }
}

modular-magician · 2023-08-14T17:47:34Z

Tests analytics

Total tests: 2945
Passed tests 2638
Skipped tests: 302
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamPolicyGenerated|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-08-14T17:53:42Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…t id

modular-magician · 2023-08-14T18:14:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    exclude_fields {
      field_names = # value needed
    }
    include_fields {
      field_names = # value needed
    }
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
    rules {
      description = # value needed
      name        = # value needed
    }
  }
}

modular-magician · 2023-08-14T19:31:10Z

Tests analytics

Total tests: 2949
Passed tests 2643
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-14T19:36:23Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…t id

modular-magician · 2023-08-15T02:44:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 613 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

modular-magician · 2023-08-15T03:54:38Z

Tests analytics

Total tests: 2949
Passed tests 2643
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-15T03:58:30Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…s on module

modular-magician · 2023-08-15T14:26:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 634 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 634 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

modular-magician · 2023-08-15T15:36:21Z

Tests analytics

Total tests: 2949
Passed tests 2641
Skipped tests: 302
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-15T15:43:38Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample[Debug log]
TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…t id

modular-magician · 2023-08-15T16:15:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 634 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 634 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

ScottSuarez · 2023-08-15T17:15:21Z

If you can't get the bigquery export tests to work we can omit them

modular-magician · 2023-08-15T17:26:26Z

Tests analytics

Total tests: 2951
Passed tests 2644
Skipped tests: 302
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryTable_HivePartitioning|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-15T17:32:29Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_HivePartitioning[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-15T20:31:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 522 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 4 files changed, 522 insertions(+), 22 deletions(-))
TF Conversion: Diff ( 3 files changed, 183 insertions(+), 3 deletions(-))

modular-magician · 2023-08-15T21:41:17Z

Tests analytics

Total tests: 2951
Passed tests 2649
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

evasharma added 2 commits August 3, 2023 15:19

update latest changes in datascan API

f31a907

Update example files for export to BQ functionality and rule names

62bfb54

modular-magician requested a review from ScottSuarez August 3, 2023 16:50

Fix lint errors in Datascan.yaml

ec060ec

ScottSuarez requested changes Aug 3, 2023

View reviewed changes

Fixes based on review feedback and additional comment fixes

badf947

modular-magician requested a review from ScottSuarez August 10, 2023 14:51

Update the examples of basic profiling and quality to fix the tests

2e75db8

Update the examples of basic profiling and quality to fix the tests

83be7ff

API field is bigqueryExport of message type BigQueryExport, fixing th…

8197746

…at in the examples in yaml

verified the format - removing the example table

051ffe1

ScottSuarez requested changes Aug 11, 2023

View reviewed changes

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

mmv1/products/dataplex/Datascan.yaml Show resolved Hide resolved

adding examples for terraform

4a1d36c

modular-magician requested a review from ScottSuarez August 12, 2023 00:21

adding example for export to BQ result table for profile - fix table …

63a450d

…path

adding example for export to BQ result table for profile - fix datase…

279b87b

…t id

adding example for export to BQ result table for profile - fix datase…

646eb4f

…t id

adding example for export to BQ result table for profile - add depend…

3a49f3c

…s on module

adding example for export to BQ result table for profile - fix datase…

906a66a

…t id

removing faulty example for export to BQ result

7e13a71

ScottSuarez approved these changes Aug 17, 2023

View reviewed changes

ScottSuarez merged commit d23370a into GoogleCloudPlatform:main Aug 17, 2023

joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023

Add the latest changes in Datascan API (GoogleCloudPlatform#8541)

5f34e11

	item_type: !ruby/object:Api::Type::String
	item_type: Api::Type::String

	item_type: !ruby/object:Api::Type::String
	item_type: item_type: Api::Type::String

Add the latest changes in Datascan API #8541

Add the latest changes in Datascan API #8541

Conversation

evasharma commented Aug 3, 2023 • edited by ScottSuarez Loading

modular-magician commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Aug 10, 2023

Diff report

Missing test report

modular-magician commented Aug 10, 2023

Tests analytics

Action taken

modular-magician commented Aug 10, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Aug 10, 2023

Diff report

Missing test report

modular-magician commented Aug 10, 2023

Tests analytics

Action taken

modular-magician commented Aug 10, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Aug 10, 2023

Diff report

modular-magician commented Aug 10, 2023

Tests analytics

Action taken

modular-magician commented Aug 10, 2023

modular-magician commented Aug 10, 2023

Diff report

modular-magician commented Aug 10, 2023

Tests analytics

Action taken

modular-magician commented Aug 10, 2023

modular-magician commented Aug 11, 2023

Diff report

Missing test report

modular-magician commented Aug 11, 2023

Tests analytics

Action taken

modular-magician commented Aug 11, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Aug 14, 2023

Diff report

Missing test report

modular-magician commented Aug 14, 2023

Tests analytics

Action taken

modular-magician commented Aug 14, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Aug 14, 2023

Diff report

Missing test report

modular-magician commented Aug 14, 2023

Tests analytics

Action taken

modular-magician commented Aug 14, 2023

modular-magician commented Aug 15, 2023

Diff report

modular-magician commented Aug 15, 2023

Tests analytics

Action taken

modular-magician commented Aug 15, 2023

modular-magician commented Aug 15, 2023

Diff report

modular-magician commented Aug 15, 2023

Tests analytics

Action taken

evasharma commented Aug 3, 2023 •

edited by ScottSuarez

Loading