Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use API's default value for enableEndpointIndependentMapping #8600

Conversation

shijeesh-ns
Copy link
Contributor

@shijeesh-ns shijeesh-ns commented Aug 10, 2023

Instead of using a hardcode default of false for enableEndpointIndependentMapping, use the default value from the API.

hashicorp/terraform-provider-google#10547

If this PR is for Terraform, I acknowledge that I have:

  • [X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: used APIs default value for field `enable_endpoint_independent_mapping` in resource `google_compute_router_nat`

Instead of using a hardcode default of `false` for
`enableEndpointIndependentMapping`, use the default value from the API.
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 10, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field enable_endpoint_independent_mapping default value changed from true to on google_compute_router_nat - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2923
Passed tests 2612
Skipped tests: 305
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccDataSourceGoogleComputeRouterNat_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRouterNat_removeLogConfig[Debug log]
TestAccComputeRouterNat_update[Debug log]
TestAccComputeRouterNat_basic[Debug log]
TestAccDataSourceGoogleComputeRouterNat_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member

zli82016 commented Aug 11, 2023

Hello, @shijeesh-ns , thanks for making the change. Can you please create a PR to add the fix to the 5.0.0 release guide in the main branch? https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown

Example: #8529

@shijeesh-ns
Copy link
Contributor Author

Hello, @shijeesh-ns , thanks for making the change. Can you please create a PR to add the fix to the 5.0.0 release guide in the main branch? https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown

Example: #8529

Created hashicorp/terraform-provider-google#15477 to track the 5.0.0 release guide updation

@zli82016
Copy link
Member

hashicorp/terraform-provider-google#15477

Thanks for creating the issue. Please make sure to update the 5.0.0 release guide soon.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit a08a156 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Aug 11, 2023
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 14, 2023
…oogleCloudPlatform#8600)

Instead of using a hardcode default of `false` for
`enableEndpointIndependentMapping`, use the default value from the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants