-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Use API's default value for enableEndpointIndependentMapping #8600
Bugfix: Use API's default value for enableEndpointIndependentMapping #8600
Conversation
Instead of using a hardcode default of `false` for `enableEndpointIndependentMapping`, use the default value from the API.
Hello! I am a robot. It looks like you are a community contributor. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccDataSourceGoogleComputeRouterNat_basic |
Rerun these tests in REPLAYING mode to catch issues
|
Hello, @shijeesh-ns , thanks for making the change. Can you please create a PR to add the fix to the 5.0.0 release guide in the main branch? https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Example: #8529 |
Created hashicorp/terraform-provider-google#15477 to track the 5.0.0 release guide updation |
Thanks for creating the issue. Please make sure to update the 5.0.0 release guide soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a08a156
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
…oogleCloudPlatform#8600) Instead of using a hardcode default of `false` for `enableEndpointIndependentMapping`, use the default value from the API.
Instead of using a hardcode default of
false
forenableEndpointIndependentMapping
, use the default value from the API.hashicorp/terraform-provider-google#10547
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)