Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark num_finite_buckets required for cloud logging metric bucket_options #8780

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Mark num_finite_buckets required for cloud logging metric bucket_options #8780

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a60aa42
disable ForceNew for project sink unique_writer_identity field
pengq-google Aug 28, 2023
cc2dacd
Mark num_finite_buckets for logging metric bucket_options required
pengq-google Aug 28, 2023
93dd1e1
Mark num_finite_buckets for logging metric bucket_options required, r…
pengq-google Aug 28, 2023
92a54ec
Mark num_finite_buckets for logging metric bucket_options required, a…
pengq-google Aug 28, 2023
341fbe8
mark child fields of bucket_options linear/exponential/explicit bucke…
pengq-google Aug 29, 2023
079d1e9
ran make fmt in local provider then copied the formatted file back.
pengq-google Aug 29, 2023
5049db1
Update mmv1/third_party/terraform/services/logging/resource_logging_p…
c2thorn Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mmv1/products/logging/Metric.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ properties:
- bucket_options.0.linear_buckets.0.offset
description: |
Must be greater than 0.
required: true
- !ruby/object:Api::Type::Double
name: width
at_least_one_of:
Expand Down Expand Up @@ -246,6 +247,7 @@ properties:
- bucket_options.0.exponential_buckets.0.scale
description: |
Must be greater than 0.
required: true
- !ruby/object:Api::Type::Double
name: growthFactor
at_least_one_of:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the requirement for at_least_one_of for all 3 of the child fields numFiniteBuckets, growthFactor, and scale

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why the build fails, the two restrictions (required, at least one of) are conflicting

Expand Down
1 change: 0 additions & 1 deletion mmv1/third_party/terraform/services/logging/resource_logging_project_sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ func ResourceLoggingProjectSink() *schema.Resource {
Type: schema.TypeBool,
Optional: true,
Default: false,
ForceNew: true,
Description: `Whether or not to create a unique identity associated with this sink. If false (the default), then the writer_identity used is serviceAccount:[email protected]. If true, then a unique service account is created and used for this sink. If you wish to publish logs across projects, you must set unique_writer_identity to true.`,
}
return schm
Expand Down