adding RestorePlan to Backup for GKE #8803

neha-vellanki12 · 2023-08-30T16:26:52Z

Adding RestorePlan resource to Backup for GKE
Part of hashicorp/terraform-provider-google#12634

If this PR is for Terraform, I acknowledge that I have:

[ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[ X] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
[X ] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
[X ] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gke_backup_restore_plan`

modular-magician · 2023-08-30T16:40:32Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-08-30T17:02:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  description = # value needed
  labels      = # value needed
  restore_config {
    cluster_resource_restore_scope {
      excluded_group_kinds {
        resource_group = # value needed
        resource_kind  = # value needed
      }
    }
    excluded_namespaces {
      namespaces = # value needed
    }
    transformation_rules {
      field_actions {
        from_path = # value needed
      }
      resource_filter {
        group_kinds {
          resource_group = # value needed
        }
      }
    }
  }
}

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-08-30T17:38:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  description = # value needed
  labels      = # value needed
  restore_config {
    cluster_resource_restore_scope {
      excluded_group_kinds {
        resource_group = # value needed
        resource_kind  = # value needed
      }
    }
    excluded_namespaces {
      namespaces = # value needed
    }
    transformation_rules {
      field_actions {
        from_path = # value needed
      }
      resource_filter {
        group_kinds {
          resource_group = # value needed
        }
      }
    }
  }
}

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-08-30T18:50:06Z

Tests analytics

Total tests: 3015
Passed tests 2711
Skipped tests: 296
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupRestorePlanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-30T19:08:55Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEBackupRestorePlanIamMemberGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamBindingGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

trodge

Could you fix the failing tests? I think the issue is mismatched resource names.

Also, could you add the fields identified by the missing test detector to at least one test?

trodge · 2023-08-31T18:01:34Z

mmv1/templates/terraform/examples/gkebackup_restoreplan_all_cluster_resources.tf.erb

+}
+
+resource "google_gke_backup_restore_plan" "all_cluster_resources" {
+  name = "rp-<%= ctx[:vars]['name'] %>"


This resource name should start with tf-test- and match the resource name in the yaml file.

tf-test should be prepended by <%= ctx[:vars]['name'] %> automatically as long as there's a hyphen in the name value!

I'm still seeing missing tests for the IAM binding. I never had to add tests for this when we added BackupPlan resource, are these tests needed?

modular-magician · 2023-09-13T16:40:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3629 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  description = # value needed
  labels      = # value needed
  restore_config {
    cluster_resource_restore_scope {
      excluded_group_kinds {
        resource_group = # value needed
        resource_kind  = # value needed
      }
    }
    excluded_namespaces {
      namespaces = # value needed
    }
    transformation_rules {
      field_actions {
        from_path = # value needed
      }
      resource_filter {
        group_kinds {
          resource_group = # value needed
        }
      }
    }
  }
}

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-13T16:57:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3785 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3785 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  description = # value needed
  labels      = # value needed
  restore_config {
    cluster_resource_restore_scope {
      excluded_group_kinds {
        resource_group = # value needed
        resource_kind  = # value needed
      }
    }
    excluded_namespaces {
      namespaces = # value needed
    }
    transformation_rules {
      field_actions {
        from_path = # value needed
      }
      resource_filter {
        group_kinds {
          resource_group = # value needed
        }
      }
    }
  }
}

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-13T18:08:14Z

Tests analytics

Total tests: 3029
Passed tests 2726
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician · 2023-09-13T18:19:20Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2ScopeIamBindingGenerated[Debug log]
TestAccGKEHub2Scope_gkehubScopeBasicExample[Debug log]
TestAccGKEHub2ScopeIamMemberGenerated[Debug log]
TestAccGKEHub2ScopeIamPolicyGenerated[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-13T19:04:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  description = # value needed
  labels      = # value needed
  restore_config {
    cluster_resource_restore_scope {
      excluded_group_kinds {
        resource_group = # value needed
        resource_kind  = # value needed
      }
    }
    excluded_namespaces {
      namespaces = # value needed
    }
    transformation_rules {
      field_actions {
        from_path = # value needed
      }
      resource_filter {
        group_kinds {
          resource_group = # value needed
        }
      }
    }
  }
}

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-13T20:15:27Z

Tests analytics

Total tests: 3029
Passed tests 2728
Skipped tests: 297
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample

Get to know how VCR tests work

modular-magician · 2023-09-13T20:25:51Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample[Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm[Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

mmv1/products/gkebackup/RestorePlan.yaml

mmv1/templates/terraform/examples/gkebackup_restoreplan_second_transformation.tf.erb

modular-magician · 2023-09-14T16:26:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-14T17:37:51Z

Tests analytics

Total tests: 3051
Passed tests 2745
Skipped tests: 297
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample

Get to know how VCR tests work

modular-magician · 2023-09-14T17:58:35Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEBackupRestorePlanIamPolicyGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamBindingGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamMemberGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-14T18:19:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-14T19:31:00Z

Tests analytics

Total tests: 3053
Passed tests 2750
Skipped tests: 298
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample

Get to know how VCR tests work

modular-magician · 2023-09-14T19:46:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEBackupRestorePlanIamPolicyGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamBindingGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamMemberGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-14T20:15:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-14T21:27:29Z

Tests analytics

Total tests: 3053
Passed tests 2750
Skipped tests: 298
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated

Get to know how VCR tests work

modular-magician · 2023-09-14T21:48:52Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample[Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEBackupRestorePlanIamPolicyGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamBindingGenerated[Error message] [Debug log]
TestAccGKEBackupRestorePlanIamMemberGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-14T22:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-14T22:43:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-14T23:36:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 3793 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 4 files changed, 999 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gke_backup_restore_plan_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-09-15T00:48:56Z

Tests analytics

Total tests: 3054
Passed tests 2746
Skipped tests: 298
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-15T01:15:21Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEBackupRestorePlanIamPolicyGenerated[Debug log]
TestAccGKEBackupRestorePlanIamBindingGenerated[Debug log]
TestAccGKEBackupRestorePlanIamMemberGenerated[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample[Debug log]
TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

* adding RestorePlan to Backup for GKE * fixed spacing issue * fixed more spacing issue * adding newline end of file * fixed trailing spaces * fixed test file names * added test gaps * adding description adn labels * fixed tests * fixed protected application name length * fixed protected app test * fix restore all namespaces test names * removed bp prefix from resource names * removed last bp ref

neha-vellanki12 added 3 commits August 30, 2023 09:21

adding RestorePlan to Backup for GKE

a0e6bb3

fixed spacing issue

98535e7

fixed more spacing issue

2685670

modular-magician requested a review from trodge August 30, 2023 16:40

neha-vellanki12 added 2 commits August 30, 2023 10:11

adding newline end of file

e2e08f3

fixed trailing spaces

1f62a0c

trodge requested changes Aug 31, 2023

View reviewed changes

fixed test file names

8177e54

modular-magician requested review from trodge and rileykarson September 13, 2023 16:31

added test gaps

bcb64e1

adding description adn labels

ae2f8cb

trodge requested changes Sep 13, 2023

View reviewed changes

mmv1/products/gkebackup/RestorePlan.yaml Show resolved Hide resolved

trodge reviewed Sep 14, 2023

View reviewed changes

mmv1/templates/terraform/examples/gkebackup_restoreplan_second_transformation.tf.erb Outdated Show resolved Hide resolved

fixed tests

a0df110

modular-magician requested a review from trodge September 14, 2023 16:18

fixed protected application name length

7b1b62c

fixed protected app test

2677fcf

fix restore all namespaces test names

61bff68

removed bp prefix from resource names

b34f2a6

removed last bp ref

356c08b

trodge approved these changes Sep 15, 2023

View reviewed changes

trodge merged commit eb0bf5c into GoogleCloudPlatform:main Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding RestorePlan to Backup for GKE #8803

adding RestorePlan to Backup for GKE #8803

neha-vellanki12 commented Aug 30, 2023

modular-magician commented Aug 30, 2023

modular-magician commented Aug 30, 2023

modular-magician commented Aug 30, 2023

modular-magician commented Aug 30, 2023

modular-magician commented Aug 30, 2023

trodge left a comment

trodge Aug 31, 2023

rileykarson Sep 7, 2023

neha-vellanki12 Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 15, 2023

modular-magician commented Sep 15, 2023

adding RestorePlan to Backup for GKE #8803

adding RestorePlan to Backup for GKE #8803

Conversation

neha-vellanki12 commented Aug 30, 2023

modular-magician commented Aug 30, 2023

modular-magician commented Aug 30, 2023

Diff report

Missing test report

modular-magician commented Aug 30, 2023

Diff report

Missing test report

modular-magician commented Aug 30, 2023

Tests analytics

Action taken

modular-magician commented Aug 30, 2023

Rerun these tests in REPLAYING mode to catch issues

trodge left a comment

Choose a reason for hiding this comment

trodge Aug 31, 2023

Choose a reason for hiding this comment

rileykarson Sep 7, 2023

Choose a reason for hiding this comment

neha-vellanki12 Sep 13, 2023

Choose a reason for hiding this comment

modular-magician commented Sep 13, 2023

Diff report

Missing test report

modular-magician commented Sep 13, 2023

Diff report

Missing test report

modular-magician commented Sep 13, 2023

Tests analytics

Action taken

modular-magician commented Sep 13, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 13, 2023

Diff report

Missing test report

modular-magician commented Sep 13, 2023

Tests analytics

Action taken

modular-magician commented Sep 13, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 14, 2023

Tests analytics

Action taken

modular-magician commented Sep 14, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 14, 2023

Tests analytics

Action taken

modular-magician commented Sep 14, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 14, 2023

Tests analytics

Action taken

modular-magician commented Sep 14, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 14, 2023

Diff report

Missing test report

modular-magician commented Sep 15, 2023

Tests analytics

Action taken

modular-magician commented Sep 15, 2023