Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the note using Create method to create google_service_networking_connection to 5.0 guide #8889

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 7, 2023

Release Note Template for Downstream PRs (will be copied)

docs: added the note using Create method to create google_service_networking_connection to 5.0 guide

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 1 file changed, 6 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 1 file changed, 6 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3018
Passed tests 2720
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@zli82016 zli82016 requested a review from c2thorn September 7, 2023 19:16
@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test


### `Create` method is used to create the resource

Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource.
Copy link
Member

@c2thorn c2thorn Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource.
`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.
  • I don't think we need to include the issue tracker, it wasn't particularly helpful for me understanding the issue.
  • When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
  • Are there any other specific steps the user needs to take when upgrading?
  • Also, can we be more specific about Patch and Create? Like "Patch endpoint" or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion.

  • When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
    • It is already taken care by using Create endpoint
  • Are there any other specific steps the user needs to take when upgrading?
    • The user does not need to take any other steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 1 file changed, 6 insertions(+))

@zli82016 zli82016 requested a review from c2thorn September 7, 2023 21:42
@zli82016 zli82016 merged commit 25a0c91 into main Sep 7, 2023
@zli82016 zli82016 deleted the service-networking-connection-create-guide branch September 7, 2023 23:12
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
…connection to 5.0 guide (GoogleCloudPlatform#8889)

* Add the note using Create method to create google_service_networking_connection to 5.0 guide

* Improve the note
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…connection to 5.0 guide (GoogleCloudPlatform#8889)

* Add the note using Create method to create google_service_networking_connection to 5.0 guide

* Improve the note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants