-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the note using Create method to create google_service_networking_connection to 5.0 guide #8889
Conversation
…connection to 5.0 guide
76e7263
to
caa9dd6
Compare
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
|
||
### `Create` method is used to create the resource | ||
|
||
Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource. | |
`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved. |
- I don't think we need to include the issue tracker, it wasn't particularly helpful for me understanding the issue.
- When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
- Are there any other specific steps the user needs to take when upgrading?
- Also, can we be more specific about Patch and Create? Like "Patch endpoint" or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
- When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
- It is already taken care by using Create endpoint
- Are there any other specific steps the user needs to take when upgrading?
- The user does not need to take any other steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanations!
…connection to 5.0 guide (GoogleCloudPlatform#8889) * Add the note using Create method to create google_service_networking_connection to 5.0 guide * Improve the note
…connection to 5.0 guide (GoogleCloudPlatform#8889) * Add the note using Create method to create google_service_networking_connection to 5.0 guide * Improve the note
Release Note Template for Downstream PRs (will be copied)