-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for certificate map datasource #8972
Add support for certificate map datasource #8972
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
...raform/services/certificatemanager/data_source_google_certificate_manager_certificate_map.go
Show resolved
Hide resolved
@ScottSuarez Could you take a look on this PR when you have some time? |
...raform/services/certificatemanager/data_source_google_certificate_manager_certificate_map.go
Show resolved
Hide resolved
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleCertificateManagerCertificateMap_basic|TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource|TestAccDataprocClusterIamPolicy|TestAccFolderIamPolicy_basic|TestAccProjectIamPolicy_invalidMembers |
Rerun these tests in REPLAYING mode to catch issues
|
Tests analyticsTotal tests:
|
Co-authored-by: Hamza Hassan <[email protected]>
Co-authored-by: Hamza Hassan <[email protected]>
The rest of CertificateManager resources will be added later in a subsequent PR.
Release Note Template for Downstream PRs (will be copied)