Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for certificate map datasource #8972

Conversation

Hamzawy63
Copy link
Contributor

  • Added a new datasource for CertificateManagerCertificateMap based on the existing terraform resource following the documentation
  • Added two tests for the datasource.
  • Added datasource documentation.

The rest of CertificateManager resources will be added later in a subsequent PR.

Release Note Template for Downstream PRs (will be copied)

google_certificate_manager_certificate_map

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 15, 2023
@Hamzawy63
Copy link
Contributor Author

@ScottSuarez Could you take a look on this PR when you have some time?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 19, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 187 insertions(+))
Terraform Beta: Diff ( 4 files changed, 187 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3071
Passed tests 2767
Skipped tests: 299
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleCertificateManagerCertificateMap_basic|TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource|TestAccDataprocClusterIamPolicy|TestAccFolderIamPolicy_basic|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleCertificateManagerCertificateMap_basic[Debug log]
TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProjectIamPolicy_invalidMembers[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 19, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 188 insertions(+))
Terraform Beta: Diff ( 4 files changed, 188 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3072
Passed tests 2772
Skipped tests: 300
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@ScottSuarez ScottSuarez merged commit fa76354 into GoogleCloudPlatform:main Sep 19, 2023
bobyu-google pushed a commit to bobyu-google/magic-modules that referenced this pull request Sep 20, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants