Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container_node_pool): support fuse csi driver for autopilot cluster #8998

Merged

Conversation

toVersus
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#15817

This PR relaxes the validation and allows to explicitly enable FUSE CSI driver on GKE Autopilot clusters.

Release Note Template for Downstream PRs (will be copied)

container: allow setting `addons_config.gcs_fuse_csi_driver_config` on `google_container_cluster` with `enable_autopilot: true`.

@toVersus toVersus force-pushed the fix/autopilot-fuse-csi-driver branch from 8997c35 to d572cbb Compare September 19, 2023 08:43
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 19, 2023
@toVersus
Copy link
Contributor Author

If additional test cases are required to cover scenarios involving GKE Autopilot clusters and the FUSE CSI driver addon, I will include a dedicated test case for this change.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3079
Passed tests 2780
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine without a new test case -- thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for FUSE CSI driver with GKE Autopilot
3 participants