-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal ipv6 prefix into compute network and subnetwork data source reference attribute #9274
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few formatting suggestions, after applying these through the UI + confirming there are no surprises in tests this should be good to go!
mmv1/third_party/terraform/services/compute/data_source_google_compute_subnetwork_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/data_source_google_compute_network_test.go
Outdated
Show resolved
Hide resolved
….markdown Co-authored-by: Riley Karson <[email protected]>
…_compute_subnetwork_test.go Co-authored-by: Riley Karson <[email protected]>
…_compute_network_test.go Co-authored-by: Riley Karson <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 26 insertions(+), 1 deletion(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 29 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleNetwork |
Rerun these tests in REPLAYING mode to catch issues
|
…rce reference attribute (#9274) Co-authored-by: Riley Karson <[email protected]>
… datasource
This PR is to make
data_source_google_compute_network
anddata_source_google_compute_subnetwork
includeinternal_ipv6_range
and_internal_ipv6_prefix
into their attribute reference respectively when they have dual stack support enabled upon creation.Added field names are based on REST API reference and compute client protobuf:
Release Note Template for Downstream PRs (will be copied)