Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal ipv6 prefix into compute network and subnetwork data source reference attribute #9274

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

Hugozys
Copy link
Contributor

@Hugozys Hugozys commented Oct 16, 2023

… datasource

This PR is to make data_source_google_compute_network and data_source_google_compute_subnetwork include internal_ipv6_range and _internal_ipv6_prefix into their attribute reference respectively when they have dual stack support enabled upon creation.
Added field names are based on REST API reference and compute client protobuf:

Release Note Template for Downstream PRs (will be copied)

compute: added `internal_ipv6_range` to `data.google_compute_network` data source and `internal_ipv6_prefix` field to `data.google_compute_subnetwork` data source

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 16, 2023
@Hugozys Hugozys changed the title Add internal ipv6 range attribute into compute network and subnetwork data source Add internal ipv6 prefix into compute network and subnetwork data source reference attribute Oct 16, 2023
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few formatting suggestions, after applying these through the UI + confirming there are no surprises in tests this should be good to go!

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 16, 2023
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 16, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 26 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 26 insertions(+), 1 deletion(-))

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 16, 2023
@Hugozys Hugozys marked this pull request as ready for review October 16, 2023 21:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 29 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 29 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3144
Passed tests 2824
Skipped tests: 318
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleNetwork

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleSubnetwork[Debug log]
TestAccDataSourceGoogleNetwork[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants