-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state upgrader to DCL resource google_dataproc_workflow_template #9432
Conversation
Tests analyticsTotal tests:
|
a319194
to
bdbd945
Compare
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Some fields are not in GA, so there could be two options to add the state upgrader migration files for the DCL resources to handle the version issue.
I chose the first option, as I think it will make the migration to MMv1 resources easier. |
I'm a little behind on reviews, adding Cameron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tpgtool changes and generated output looks good to me
terraform_labels
with state upgrader for resourcegoogle_dataproc_workflow_template
.gke_cluster_config
andmetastore_config
are beta only fields.Tested the provider upgrade locally from 4.84 and 5.5 respectively.
Release Note Template for Downstream PRs (will be copied)