Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state upgrader to DCL resource google_dataproc_workflow_template #9432

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Nov 8, 2023

  1. Added the state upgrader override to DCL resources.
  2. Backfilled the field terraform_labels with state upgrader for resource google_dataproc_workflow_template. gke_cluster_config and metastore_config are beta only fields.

Tested the provider upgrade locally from 4.84 and 5.5 respectively.

Release Note Template for Downstream PRs (will be copied)

dataproc: backfilled the field `terraform_labels` for resource `google_dataproc_workflow_template`, so the resource recreation will not happen during the provider upgrade from `4.x` to `5.7`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 2131 insertions(+))
Terraform Beta: Diff ( 3 files changed, 2147 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3223
Passed tests 2895
Skipped tests: 328
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 force-pushed the state-upgrader-labels branch from a319194 to bdbd945 Compare November 8, 2023 22:01
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 2131 insertions(+))
Terraform Beta: Diff ( 3 files changed, 2147 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3223
Passed tests 2894
Skipped tests: 328
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member Author

zli82016 commented Nov 8, 2023

Some fields are not in GA, so there could be two options to add the state upgrader migration files for the DCL resources to handle the version issue.

  1. Add the migration file with version guard to the handwritten folder mmv1/third_party/terrform/services/XXXX.
  2. Add the version specific migration file to the new folders tpgtools/ga/services/XXXX and tpgtools/beta/services/XXXX.

I chose the first option, as I think it will make the migration to MMv1 resources easier.

@zli82016 zli82016 requested a review from rileykarson November 8, 2023 23:39
@rileykarson rileykarson requested review from c2thorn and removed request for c2thorn and rileykarson November 8, 2023 23:42
@rileykarson
Copy link
Member

I'm a little behind on reviews, adding Cameron

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tpgtool changes and generated output looks good to me

@zli82016 zli82016 merged commit 2c9c29c into main Nov 13, 2023
11 checks passed
@zli82016 zli82016 deleted the state-upgrader-labels branch November 13, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants