feat(vertexai): Add IAM resources for Vertex AI Endpoint #9454

shotarok · 2023-11-11T06:08:49Z

fixes hashicorp/terraform-provider-google#14630
relates to #7965
relates to hashicorp/terraform-provider-google#16478

Release Note Template for Downstream PRs (will be copied)

vertexai: Added IAM resources for google_vertex_ai_endpoint (beta)

modular-magician · 2023-11-11T06:10:05Z

Hello! I am a robot. It looks like you are a: Community Contributor ~~Googler~~ ~~Core Contributor~~. Tests will require approval to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-11-13T17:44:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 221 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 828 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 374 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_vertex_ai_endpoint_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-11-13T18:58:07Z

Tests analytics

Total tests: 3227
Passed tests 2894
Skipped tests: 329
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerDatabaseIamPolicy|TestAccVertexAIEndpointIamMemberGenerated|TestAccVertexAIEndpointIamBindingGenerated|TestAccVertexAIEndpointIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-11-13T19:09:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIEndpointIamMemberGenerated[Error message] [Debug log]
TestAccVertexAIEndpointIamBindingGenerated[Error message] [Debug log]
TestAccVertexAIEndpointIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

c2thorn · 2023-11-13T19:24:01Z

    Error: Import id "tf-test-endpoint-namerj9acusjjt" doesn't match any of the accepted formats: [projects/(?P<project>[^/]+)/locations/(?P<location>[^/]+)/endpoints/(?P<endpoint>[^/]+) (?P<project>[^/]+)/(?P<location>[^/]+)/(?P<endpoint>[^/]+) (?P<location>[^/]+)/(?P<endpoint>[^/]+)]

shotarok · 2023-11-13T19:54:04Z

Thanks for putting the error message as a comment. I saw a similar error when I ran a test locally, and I thought defining ImportStateId would have solved the error. Will check.

c2thorn · 2023-11-15T13:23:38Z

Will be OOO for a while, reassigning a random reviewer to carry this forward once ready.

shotarok · 2023-11-15T22:38:07Z

I overlooked a change I made locally. I added the update in 41ef139.

shotarok · 2023-11-15T22:39:03Z

@trodge If this PR looks good, could you approve the cloud builder job?

modular-magician · 2023-11-16T18:07:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 222 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 829 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 374 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_vertex_ai_endpoint_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-11-16T19:20:35Z

Tests analytics

Total tests: 3235
Passed tests 2901
Skipped tests: 330
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccVertexAIEndpointIamPolicyGenerated|TestAccVertexAIEndpointIamMemberGenerated|TestAccVertexAIEndpointIamBindingGenerated

Get to know how VCR tests work

modular-magician · 2023-11-16T19:34:59Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccVertexAIEndpointIamPolicyGenerated[Debug log]
TestAccVertexAIEndpointIamMemberGenerated[Debug log]
TestAccVertexAIEndpointIamBindingGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

trodge

Found a couple nits after approving.

trodge · 2023-11-16T20:03:17Z

mmv1/templates/terraform/iam/example_config_body/vertex_ai_endpoint.tf.erb

@@ -0,0 +1,3 @@
+project = google_vertex_ai_endpoint.endpoint.project


nit: these lines should be indented with two spaces so that they fit in the documentation and generated test.

trodge · 2023-11-16T20:03:58Z

mmv1/third_party/terraform/services/vertexai/iam_vertex_endpoint_test.go.erb

+	"github.com/hashicorp/terraform-provider-google/google/envvar"
+)
+
+func TestAccVertexAIEndpointIamBindingGenerated(t *testing.T) {


Suggested change

func TestAccVertexAIEndpointIamBindingGenerated(t *testing.T) {

func TestAccVertexAIEndpointIamBinding(t *testing.T) {

This test can be renamed since it is not being generated by building mmv1.

shotarok · 2023-11-16T20:48:09Z

@trodge Hello 👋 Thank you for your reviews! I pushed the updates. Could you approve the cloud builder job again?

modular-magician · 2023-11-16T21:00:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 222 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 829 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 374 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_vertex_ai_endpoint_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2023-11-16T22:15:40Z

Tests analytics

Total tests: 3235
Passed tests 2902
Skipped tests: 330
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVertexAIEndpointIamPolicy|TestAccVertexAIEndpointIamMember|TestAccVertexAIEndpointIamBinding

Get to know how VCR tests work

modular-magician · 2023-11-16T22:29:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIEndpointIamPolicy[Debug log]
TestAccVertexAIEndpointIamMember[Debug log]
TestAccVertexAIEndpointIamBinding[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…Platform#9454) * feat(vertexai): iam resources for vertex ai prediction * fix: update the import format * refactor: add two spaces for docs * refactor: remove the suffix 'generated' from the hand-written tests

feat(vertexai): iam resources for vertex ai prediction

30d7194

modular-magician requested a review from c2thorn November 11, 2023 06:10

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 11, 2023

c2thorn requested review from a team and trodge and removed request for c2thorn and a team November 15, 2023 13:23

fix: update the import format

41ef139

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 15, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 16, 2023

trodge approved these changes Nov 16, 2023

View reviewed changes

trodge requested changes Nov 16, 2023

View reviewed changes

shotarok added 2 commits November 16, 2023 12:14

refactor: add two spaces for docs

67eb084

refactor: remove the suffix 'generated' from the hand-written tests

b159279

modular-magician requested a review from trodge November 16, 2023 20:47

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 16, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 16, 2023

trodge approved these changes Nov 17, 2023

View reviewed changes

trodge merged commit 6b15a46 into GoogleCloudPlatform:main Nov 17, 2023
6 checks passed

shotarok deleted the vertex-ai-index-iam branch November 20, 2023 21:27

pengq-google mentioned this pull request Jan 15, 2024

Adds support for IAM Policies for Cloud Logging LogView [working in progress] #9784

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vertexai): Add IAM resources for Vertex AI Endpoint #9454

feat(vertexai): Add IAM resources for Vertex AI Endpoint #9454

shotarok commented Nov 11, 2023 •

edited

Loading

modular-magician commented Nov 11, 2023

modular-magician commented Nov 13, 2023

modular-magician commented Nov 13, 2023

modular-magician commented Nov 13, 2023

c2thorn commented Nov 13, 2023

shotarok commented Nov 13, 2023

c2thorn commented Nov 15, 2023

shotarok commented Nov 15, 2023 •

edited

Loading

shotarok commented Nov 15, 2023

modular-magician commented Nov 16, 2023

modular-magician commented Nov 16, 2023

modular-magician commented Nov 16, 2023

trodge left a comment

trodge Nov 16, 2023

trodge Nov 16, 2023

shotarok commented Nov 16, 2023

modular-magician commented Nov 16, 2023

modular-magician commented Nov 16, 2023

modular-magician commented Nov 16, 2023

		@@ -0,0 +1,3 @@
		project = google_vertex_ai_endpoint.endpoint.project

	func TestAccVertexAIEndpointIamBindingGenerated(t *testing.T) {
	func TestAccVertexAIEndpointIamBinding(t *testing.T) {

feat(vertexai): Add IAM resources for Vertex AI Endpoint #9454

feat(vertexai): Add IAM resources for Vertex AI Endpoint #9454

Conversation

shotarok commented Nov 11, 2023 • edited Loading

modular-magician commented Nov 11, 2023

modular-magician commented Nov 13, 2023

Diff report

Missing test report

modular-magician commented Nov 13, 2023

Tests analytics

Action taken

modular-magician commented Nov 13, 2023

Rerun these tests in REPLAYING mode to catch issues

c2thorn commented Nov 13, 2023

shotarok commented Nov 13, 2023

c2thorn commented Nov 15, 2023

shotarok commented Nov 15, 2023 • edited Loading

shotarok commented Nov 15, 2023

modular-magician commented Nov 16, 2023

Diff report

Missing test report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

Rerun these tests in REPLAYING mode to catch issues

trodge left a comment

Choose a reason for hiding this comment

trodge Nov 16, 2023

Choose a reason for hiding this comment

trodge Nov 16, 2023

Choose a reason for hiding this comment

shotarok commented Nov 16, 2023

modular-magician commented Nov 16, 2023

Diff report

Missing test report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

Rerun these tests in REPLAYING mode to catch issues

shotarok commented Nov 11, 2023 •

edited

Loading

shotarok commented Nov 15, 2023 •

edited

Loading