Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GKE Addon StatefulHA #9481

Merged

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Nov 16, 2023

Add support for GKE Addon StatefulHA

This PR allows add-on stateful_ha_config to be provided on the GKE Standard cluster resource. This enables cluster creation and update to toggle this add-on.

  • 3.1 the resource schema added in the PR matches the API structure.
  • 4.1 all fields added/updated in the PR appear in at least one test.
  • 4.2 all mutable fields are tested in at least one update test.
  • 4.8 all related PR presubmit tests have been completed successfully
  • 5.2 documentation is added manually for handwritten resources.
  • 6 Check if release notes capture all changes in the PR, and are correctly formatted following the guidance in write release notes before merge the PR.

Release Note Template for Downstream PRs (will be copied)

container: added field `stateful_ha_config` for `resource_container_cluster`.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 16, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 384 insertions(+), 325 deletions(-))
Terraform Beta: Diff ( 3 files changed, 420 insertions(+), 371 deletions(-))

@pwschuurman pwschuurman force-pushed the stateful-ha-tf-changes branch from eb6e88d to 2843fae Compare April 1, 2024 23:33
@pwschuurman pwschuurman marked this pull request as ready for review April 1, 2024 23:43
@pwschuurman pwschuurman changed the title [WIP]: Add support for GKE Addon StatefulHA Add support for GKE Addon StatefulHA Apr 1, 2024
@trodge
Copy link
Contributor

trodge commented Apr 2, 2024

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2024
@melinath melinath requested review from a team and hao-nan-li and removed request for trodge and a team April 5, 2024 22:04
@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 43 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 189
Passed tests: 176
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withAddons

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withAddons[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@hao-nan-li hao-nan-li merged commit 0f61d38 into GoogleCloudPlatform:main Apr 8, 2024
15 of 17 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants