Update make transferJobs name field optional

[mohsenmottaghi]

Fix hashicorp/terraform-provider-google#15220

This PR tries to make the name field of transferJobs service optional to be able to have customized names for storage transfer jobs.

Release Note Template for Downstream PRs (will be copied)

storagetransfer: made `name` field to be optional in resource `google_storage_transfer_job` so it can be provided by the users

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[zli82016]

@mohsenmottaghi , can you please add a test that name is specified in the configuration for google_storage_transfer_job? Thanks.

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/storagetransfer/resource_storage_transfer_job_test.go

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3293
Passed tests 2955
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zli82016]

Need to add a test

[mohsenmottaghi]

@mohsenmottaghi , can you please add a test that name is specified in the configuration for google_storage_transfer_job? Thanks.

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/storagetransfer/resource_storage_transfer_job_test.go

Yes, I added TestAccStorageTransferJob_transferJobName test that tries to create a transfer job with a dynamic name with tf-test-transfer-job-%s format. Please review my changes and If you think they need more changes let me know to do it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 107 insertions(+))
Terraform Beta: Diff ( 3 files changed, 107 insertions(+))

[zli82016]

@mohsenmottaghi , can you please add a test that name is specified in the configuration for google_storage_transfer_job? Thanks.
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/storagetransfer/resource_storage_transfer_job_test.go

Yes, I added TestAccStorageTransferJob_transferJobName test that tries to create a transfer job with a dynamic name with tf-test-transfer-job-%s format. Please review my changes and If you think they need more changes let me know to do it.

Thanks for adding the test.

[modular-magician]

Tests analytics

Total tests: 3302
Passed tests 2964
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageTransferJob_transferJobName

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageTransferJob_transferJobName[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 107 insertions(+))
Terraform Beta: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3301
Passed tests 2964
Skipped tests: 336
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zli82016]

LGTM

[zli82016]

I added the release note for this PR. Please provider it for other PRs.

[mohsenmottaghi]

I added the release note for this PR. Please provider it for other PRs.

Thanks 🙏