Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bq analyticshub listing - add support for restrictedExportConfig #9661

Merged
merged 3 commits into from
Dec 20, 2023
Merged

bq analyticshub listing - add support for restrictedExportConfig #9661

merged 3 commits into from
Dec 20, 2023

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Dec 15, 2023 •
edited by melinath
Loading

Release Note Template for Downstream PRs (will be copied)

bigqueryanalyticshub: added `restricted_export_config` field to `google_bigquery_analytics_hub_listing ` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 15, 2023
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3300
Passed tests 2899
Skipped tests: 337
Affected tests: 64

Action taken

Found 64 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccProviderBasePath_setBasePath|TestAccDefaultUniverseDomainDisk|TestAccAccessApprovalSettings|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccAppEngineStandardAppVersion_update|TestAccArtifactRegistryRepository_kfp|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccArtifactRegistryRepositoryIamBindingGenerated|TestAccArtifactRegistryRepository_remote|TestAccArtifactRegistryRepository_artifactRegistryRepositoryDockerExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccDataSourceGoogleBackupDRManagementServer_basic|TestAccBiglakeTable_biglakeTable_update|TestAccBigQueryDataTable_sheet|TestAccBigQueryJob_bigqueryJobLoadParquetExample|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingRestrictedExample|TestAccBigqueryAnalyticsHubDataExchangeIamBindingGenerated|TestAccBigqueryAnalyticsHubDataExchange_bigqueryAnalyticshubDataExchangeBasicExample|TestAccBigqueryConnectionConnection_bigqueryConnectionAzureExample|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDataTransferConfig|TestAccBigqueryReservationBiReservation_update|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccBinaryAuthorizationAttestorIamBindingGenerated|TestAccBinaryAuthorizationAttestorIamPolicyGenerated|TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudBuildTrigger_cloudbuildTriggerAllowExitCodesExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudBuildTrigger_webhook_config|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudbuildv2Connection_GheCompleteConnection|TestAccCloudbuildv2ConnectionIamBindingGenerated|TestAccCloudbuildv2Repository_GheRepository|TestAccCloudbuildv2Repository_GitlabRepository|TestAccCloudbuildv2Connection_GhePrivConnection|TestAccCloudbuildv2Connection_GitlabConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample|TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudIdentityGroup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProviderBasePath_setBasePath[Debug log]
TestAccDefaultUniverseDomainDisk[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbCluster_mandatoryFields[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]
TestAccArtifactRegistryRepository_kfp[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Debug log]
TestAccArtifactRegistryRepositoryIamBindingGenerated[Debug log]
TestAccArtifactRegistryRepository_remote[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryDockerExample[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample[Debug log]
TestAccAssuredWorkloadsWorkload_FullHandWritten[Debug log]
TestAccAssuredWorkloadsWorkload_BasicHandWritten[Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic[Debug log]
TestAccBiglakeTable_biglakeTable_update[Debug log]
TestAccBigQueryDataTable_sheet[Debug log]
TestAccBigQueryJob_bigqueryJobLoadParquetExample[Debug log]
TestAccBigQueryJob_bigqueryJobCopyExample[Debug log]
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingRestrictedExample[Debug log]
TestAccBigqueryAnalyticsHubDataExchangeIamBindingGenerated[Debug log]
TestAccBigqueryAnalyticsHubDataExchange_bigqueryAnalyticshubDataExchangeBasicExample[Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAzureExample[Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccBigqueryDataTransferConfig[Debug log]
TestAccBigqueryReservationBiReservation_update[Debug log]
TestAccDataSourceGoogleBillingAccount_byFullName[Debug log]
TestAccBinaryAuthorizationAttestorIamBindingGenerated[Debug log]
TestAccBinaryAuthorizationAttestorIamPolicyGenerated[Debug log]
TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample[Debug log]
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Debug log]
TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample[Debug log]
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerAllowExitCodesExample[Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample[Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Debug log]
TestAccCloudBuildTrigger_webhook_config[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample[Debug log]
TestAccCloudbuildv2Connection_GheCompleteConnection[Debug log]
TestAccCloudbuildv2ConnectionIamBindingGenerated[Debug log]
TestAccCloudbuildv2Repository_GheRepository[Debug log]
TestAccCloudbuildv2Repository_GitlabRepository[Debug log]
TestAccCloudbuildv2Connection_GhePrivConnection[Debug log]
TestAccCloudbuildv2Connection_GitlabConnection[Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Debug log]
TestAccCloudbuildv2Connection_GleConnection[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample[Debug log]
TestAccCloudfunctions2function_cloudfunctions2PrivateWorkerpoolExample[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[Debug log]
TestAccCloudIdentityGroup[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAccessApprovalSettings[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath
melinath approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@melinath melinath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM - fairly straightforward. I'm going to make one tweak to a field's docs and update the release note per https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/, then merge.

mmv1/products/bigqueryanalyticshub/Listing.yaml Outdated Show resolved Hide resolved
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 20, 2023
@melinath melinath merged commit 9baa61f into GoogleCloudPlatform:main Dec 20, 2023
7 checks passed
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 20, 2023
@DrFaust92 DrFaust92 deleted the bq_listing_restricted branch December 20, 2023 18:46
This was referenced Dec 20, 2023
Merged
Merged
Merged
Merged
melinath
melinath reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@DrFaust92 @melinath @kapreus
bq analyticshub listing - add support for restrictedExportConfig (Goo…
b88a342 
…gleCloudPlatform#9661)

* bq analyticshub listing - add support for restrictedExportConfig

* lint

* Update mmv1/products/bigqueryanalyticshub/Listing.yaml

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@DrFaust92 @melinath @balanaguharsha
bq analyticshub listing - add support for restrictedExportConfig (Goo…
ecbc730 
…gleCloudPlatform#9661)

* bq analyticshub listing - add support for restrictedExportConfig

* lint

* Update mmv1/products/bigqueryanalyticshub/Listing.yaml

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@DrFaust92 @melinath @pengq-google
bq analyticshub listing - add support for restrictedExportConfig (Goo…
283841a 
…gleCloudPlatform#9661)

* bq analyticshub listing - add support for restrictedExportConfig

* lint

* Update mmv1/products/bigqueryanalyticshub/Listing.yaml

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @modular-magician @melinath