Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote enable_confidential_compute for disks to v1. #9789

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

harshulsoni
Copy link
Contributor

@harshulsoni harshulsoni commented Jan 10, 2024

Promote enable_confidential_compute for disks and create-on-create attached disks to v1.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `google_compute_disk.enable_confidential_compute` to GA
compute: added `enable_confidential_compute` field to `google_compute_instance.boot_disk.initialize_params`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 162 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 5 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 863
Passed tests 797
Skipped tests: 65
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_confidentialHyperDiskBootDisk

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_confidentialHyperDiskBootDisk[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 165 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 11 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 863
Passed tests 798
Skipped tests: 64
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -433,7 +433,6 @@ properties:
description: |
Whether this disk is using confidential compute mode.
Note: Only supported on hyperdisk skus, disk_encryption_key is required when setting to true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to verify that this is correct, since it's not mentioned in the API docs? If not, could be good to fix in a follow-on PR.

@melinath melinath merged commit 20d545e into GoogleCloudPlatform:main Jan 10, 2024
12 checks passed
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
…form#9789)

* Promote enable_confidential_compute for disks to v1.

* Enable confidential hyperdisk test for `google_compute_disk.
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
…form#9789)

* Promote enable_confidential_compute for disks to v1.

* Enable confidential hyperdisk test for `google_compute_disk.
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…form#9789)

* Promote enable_confidential_compute for disks to v1.

* Enable confidential hyperdisk test for `google_compute_disk.
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…form#9789)

* Promote enable_confidential_compute for disks to v1.

* Enable confidential hyperdisk test for `google_compute_disk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants