-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote enable_confidential_compute for disks to v1. #9789
Conversation
Hello! I am a robot. It looks like you are a: @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 162 insertions(+), 7 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_confidentialHyperDiskBootDisk |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/compute/resource_compute_disk_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 165 insertions(+), 7 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeDisk_pdHyperDiskEnableConfidentialCompute |
Rerun these tests in REPLAYING mode to catch issues
|
Note for self: running GA tests manually just to be safe: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_Google_MmUpstreamTesting_GOOGLE_PACKAGE_COMPUTE/83884?hideProblemsFromDependencies=false&hideTestsFromDependencies=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -433,7 +433,6 @@ properties: | |||
description: | | |||
Whether this disk is using confidential compute mode. | |||
Note: Only supported on hyperdisk skus, disk_encryption_key is required when setting to true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to verify that this is correct, since it's not mentioned in the API docs? If not, could be good to fix in a follow-on PR.
…form#9789) * Promote enable_confidential_compute for disks to v1. * Enable confidential hyperdisk test for `google_compute_disk.
…form#9789) * Promote enable_confidential_compute for disks to v1. * Enable confidential hyperdisk test for `google_compute_disk.
…form#9789) * Promote enable_confidential_compute for disks to v1. * Enable confidential hyperdisk test for `google_compute_disk.
…form#9789) * Promote enable_confidential_compute for disks to v1. * Enable confidential hyperdisk test for `google_compute_disk.
Promote enable_confidential_compute for disks and create-on-create attached disks to v1.
Release Note Template for Downstream PRs (will be copied)