Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw an error when configured universe differs from assumed default #9799

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jan 11, 2024

Release Note Template for Downstream PRs (will be copied)

provider: fixed `universe_domain` behavior to correctly throw an error when explicitly configured `domain_universe` values did not match credentials assumed to be in the default universe

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 19 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 19 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3342
Passed tests 3004
Skipped tests: 337
Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from rileykarson January 11, 2024 16:46
@rileykarson rileykarson merged commit 27a784a into GoogleCloudPlatform:main Jan 16, 2024
13 checks passed
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants