Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enableHistoryModifications in FHIR Stores #9823

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

FaithfulZhening
Copy link
Contributor

@FaithfulZhening FaithfulZhening commented Jan 15, 2024

Fixes hashicorp/terraform-provider-google#17005

Release Note Template for Downstream PRs (will be copied)

healthcare: added `enable_history_modifications` field to `google_healthcare_fhir_store` resource (beta)

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 40 insertions(+))
Terraform Beta: Diff ( 3 files changed, 40 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests 37
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016
Copy link
Member

zli82016 commented Jan 16, 2024

@FaithfulZhening, thanks for making the change. Can you please add the update test for this new field to check if updating works or not? Thanks.
https://googlecloudplatform.github.io/magic-modules/develop/test/#add-an-update-test

You can add the new field to the existing test https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/healthcare/resource_healthcare_fhir_store_test.go.erb#L78

@zli82016
Copy link
Member

zli82016 commented Jan 16, 2024

As the new field is only available in beta, the version guard for the new field can be used in the update test.

Example https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/compute/resource_compute_autoscaler_test.go.erb#L305

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 10 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 44 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests 36
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • healthcare

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccHealthcareFhirStore_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareFhirStore_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 7 insertions(+))
Terraform Beta: Diff ( 4 files changed, 43 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests 37
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 self-requested a review January 17, 2024 03:27
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 5d303ae into GoogleCloudPlatform:main Jan 17, 2024
12 checks passed
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
…dPlatform#9823)

* initial commit

* clean unused code

* add test.

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb

* Move to beta example

* Update resource_healthcare_fhir_store_test.go.erb

* Add version guard

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
…dPlatform#9823)

* initial commit

* clean unused code

* add test.

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb

* Move to beta example

* Update resource_healthcare_fhir_store_test.go.erb

* Add version guard

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…dPlatform#9823)

* initial commit

* clean unused code

* add test.

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb

* Move to beta example

* Update resource_healthcare_fhir_store_test.go.erb

* Add version guard

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…dPlatform#9823)

* initial commit

* clean unused code

* add test.

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb

* Move to beta example

* Update resource_healthcare_fhir_store_test.go.erb

* Add version guard

* Update resource_healthcare_fhir_store_test.go.erb

* Update resource_healthcare_fhir_store_test.go.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enableHistoryModifications in FHIR Stores
3 participants