-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enableHistoryModifications in FHIR Stores #9823
Conversation
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 40 insertions(+)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
@FaithfulZhening, thanks for making the change. Can you please add the update test for this new field to check if updating works or not? Thanks. You can add the new field to the existing test https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/healthcare/resource_healthcare_fhir_store_test.go.erb#L78 |
mmv1/templates/terraform/examples/healthcare_fhir_store_basic.tf.erb
Outdated
Show resolved
Hide resolved
As the new field is only available in beta, the version guard for the new field can be used in the update test. |
Tests analyticsTotal tests: Click here to see the affected service packages
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 10 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareFhirStore_basic |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/healthcare/resource_healthcare_fhir_store_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/healthcare/resource_healthcare_fhir_store_test.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 7 insertions(+)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dPlatform#9823) * initial commit * clean unused code * add test. * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb * Move to beta example * Update resource_healthcare_fhir_store_test.go.erb * Add version guard * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb
…dPlatform#9823) * initial commit * clean unused code * add test. * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb * Move to beta example * Update resource_healthcare_fhir_store_test.go.erb * Add version guard * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb
…dPlatform#9823) * initial commit * clean unused code * add test. * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb * Move to beta example * Update resource_healthcare_fhir_store_test.go.erb * Add version guard * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb
…dPlatform#9823) * initial commit * clean unused code * add test. * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb * Move to beta example * Update resource_healthcare_fhir_store_test.go.erb * Add version guard * Update resource_healthcare_fhir_store_test.go.erb * Update resource_healthcare_fhir_store_test.go.erb
Fixes hashicorp/terraform-provider-google#17005
Release Note Template for Downstream PRs (will be copied)