Expose version_id on google_cloudfunctions_function #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
modular-magician
added
awaiting-approval
Tests analyticsTotal tests: Click here to see the affected service packages
|
melinath
requested changes
Feb 13, 2024
| @@ -490,6 +490,11 @@ func ResourceCloudFunctionsFunction() *schema.Resource { | |||
| Computed: true, | |||
| Description: `Describes the current stage of a deployment.`, | |||
| }, | |||
| "version_id": { | |||
| Type: schema.TypeInt, | |||
There was a problem hiding this comment.
It looks like this is a string (int64) in the API, so it should be represented as a string in Terraform for consistency. TypeInt can't reliably represent int64 values.
drcapulet
force-pushed
the
alexc-expose-cf-version-id
branch
from
bb96d29 to
a9d2b1b
Compare
|
/gcbrun |
modular-magician
added
awaiting-approval
Tests analyticsTotal tests: Click here to see the affected service packages
|
melinath
approved these changes
Feb 14, 2024
This was referenced Feb 14, 2024
Merged
Merged
tdbhacks
pushed a commit
to tdbhacks/magic-modules
that referenced
this pull request
Feb 23, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
Apr 19, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already in the YAML but the lookup has custom code so it wasn't exposed - updated the type to be an integer since that's what the Go SDK returns, but happy to keep it a string.
Release Note Template for Downstream PRs (will be copied)