Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating NIC stack type for google compute instance #9983

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Timus1712
Copy link
Contributor

Support updating StackType of NetworkInterface of google_compute_instance resource. Previously it was ignored which made it impossible to update.

Fixes hashicorp/terraform-provider-google#17210

Release Note Template for Downstream PRs (will be copied)

compute: support updating `network_interface.stack_type` field on `google_compute_instance` resource.

@Timus1712 Timus1712 requested a review from a team as a code owner February 14, 2024 12:07
@Timus1712 Timus1712 requested review from trodge and removed request for a team February 14, 2024 12:07
@trodge
Copy link
Contributor

trodge commented Feb 14, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 92 insertions(+))
Terraform Beta: Diff ( 2 files changed, 92 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 886
Passed tests: 811
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_NicStackTypeUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_NicStackTypeUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@Timus1712 Timus1712 force-pushed the fix_update_stack_type branch from 4ceaa56 to d1e3709 Compare February 15, 2024 14:21
@modular-magician
Copy link
Collaborator

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 92 insertions(+))
Terraform Beta: Diff ( 2 files changed, 92 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 886
Passed tests: 812
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_NicStackTypeUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_NicStackTypeUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge merged commit a7be02a into GoogleCloudPlatform:main Feb 15, 2024
11 of 12 checks passed
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Feb 29, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 6, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Mar 11, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update value of network_interface.stack_type on google_compute_instance resources
3 participants