-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
try_files $uri /index.php$is_args$args; | ||
} | ||
``` | ||
|
||
I hope this mechanism can cover most of the web frameworks, but let us | ||
You might need to add some rewrite rules, or you might want to change | ||
the behavior. In those cases, put a file named `nginx-app.conf` in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony uses app.php
in the root of the project as a convention, so you should also add instructions on how to do this:
In this case,
index.php
is used as the framework front controller. You may need to change this to something different for your project. The Symfony framework, for instance, usesapp.php
instead ofindex.php
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to the suggested edit above.
301a530
to
018b2ff
Compare
It would be great to include a section with the proper
|
@bshaffer Great suggestion, but I want put those info on our documentation, not on the |
We exhausted quotas for Container Builder API. Probably I've worked too much today! |
+1 for adding it to the documentation. Great and necessary addition 👍 IMHO documentation is the single most important bit you can provide besides the image. "The 3 step guide to run $product" [with some sidenotes] would be really nice. |
Ok, let's add the document, but can we do that in another PR? I filed #140 for discussion |
@bshaffer PTAL! |
LGTM! |
Alright, the current image is available at: Please feel free to test it. You may still get a nasty permission error if you try to modify files in sub directories in ${APP_DIR} due to moby/moby#6047 Possible wordarounds:
|
@bshaffer tried that image and gave good feedback. We should loosen suhosin etc for php cli. I'll work on that next and I'll stage the image again, after doing do. |
See also #141 |
Note: with this image, we can just remove the
nginx-app.conf
in our most of the (probably all?) sample applications.