Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Onboard American Community Survey dataset #222

Merged
merged 23 commits into from
Dec 29, 2021
Merged

feat: Onboard American Community Survey dataset #222

merged 23 commits into from
Dec 29, 2021

Conversation

dipannitab2392
Copy link
Contributor

@dipannitab2392 dipannitab2392 commented Nov 3, 2021 •
edited
Loading

Description

Pipeline List :

  • census_bureau_acs/cbsa_2019_5yr
  • census_bureau_acs/congressionaldistrict_2019_1yr
  • census_bureau_acs/congressionaldistrict_2019_5yr
  • census_bureau_acs/county_2019_1yr
  • census_bureau_acs/county_2019_5yr
  • census_bureau_acs/place_2019_1yr
  • census_bureau_acs/place_2019_5yr
  • census_bureau_acs/cbsa_2019_1yr
  • census_bureau_acs/puma_2019_1yr
  • census_bureau_acs/puma_2019_5yr
  • census_bureau_acs/schooldistrictelementary_2019_1yr
  • census_bureau_acs/schooldistrictelementary_2019_5yr
  • census_bureau_acs/schooldistrictsecondary_2019_1yr
  • census_bureau_acs/schooldistrictsecondary_2019_5yr
  • census_bureau_acs/schooldistrictunified_2019_1yr
  • census_bureau_acs/schooldistrictunified_2019_5yr
  • census_bureau_acs/state_2019_1yr
  • census_bureau_acs/state_2019_5yr
  • census_bureau_acs/zcta_2019_5yr

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/census_bureau_acs and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@dipannitab2392 dipannitab2392 requested review from adlersantos and removed request for leahecole November 3, 2021 16:45
adlersantos
adlersantos reviewed Nov 5, 2021
View reviewed changes
Pipfile Outdated Show resolved Hide resolved
@dipannitab2392 dipannitab2392 added the data onboarding Onboard a dataset or submit a pipeline label Nov 12, 2021
adlersantos
adlersantos requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the schedule to @once

Pipfile Outdated Show resolved Hide resolved
adlersantos
adlersantos requested changes Dec 8, 2021
View reviewed changes
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated
"B25035001": "median_year_structure_built",
}

state_code = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can the same here (separate file loaded)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created separate json file

datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/cbsa_2019_1yr/pipeline.yaml Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/census_bureau_acs/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
@adlersantos adlersantos merged commit 861d0e6 into GoogleCloudPlatform:main Dec 29, 2021
@release-please release-please bot mentioned this pull request Jan 12, 2022
Merged
@dipannitab2392 dipannitab2392 mentioned this pull request Jan 13, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

Assignees
No one assigned
Labels
cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipannitab2392 @adlersantos