Add json flag for ctc_lib. #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
commented
Apr 17, 2018
| if displayError != nil { | ||
| Log.Errorf("%v", commandError) | ||
| } | ||
| if commandError != nil && displayError != nil { |
tejal29
commented
Apr 17, 2018
| @@ -74,6 +74,9 @@ func (ctb *ContainerToolCommandBase) AddSubCommands() { | |||
|
|
|||
| // Set up Root Command | |||
| ctb.Command.SetHelpTemplate(HelpTemplate) | |||
|
|
|||
| // Donot display usage when using RunE | |||
| ctb.SilenceUsage = true | |||
There was a problem hiding this comment.
Add spf13/cobra#340 issue link to why we need to force this to be true.
| LogIfErr(totalError, Log) | ||
|
|
||
| if commandError != nil && totalError != nil { | ||
| return errors.New("One or more errors") |
There was a problem hiding this comment.
Are errors handled the same way if json output is used? It might be worth adding some test cases for failing commands as well in another PR.
There was a problem hiding this comment.
will add tests in this PR :) Thanks @aaron-prindle.
aaron-prindle
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.